Skip to content

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented Nov 21, 2021

close #796

@taooceros taooceros requested a review from jjw24 November 21, 2021 21:16
<!-- Setting General -->
<system:String x:Key="flowlauncher_settings">Nastavenia Flow Launchera</system:String>
<system:String x:Key="general">Všeobecné</system:String>
<system:String x:Key="general">Všeobecn</system:String>
Copy link
Contributor

@kubalav kubalav Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is letter "é" cut off? These changes does not come from me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some translation is loaded in a shared memory way? So a bit character seems being cut off? I don't know how crowdin implement that but I do find that chinese translation also get a bit cut off as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably some special character are ignored there....Would you please do a proofread for that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All occurrences fixed!
I found that it's occurred if character "é" is followed by "<" only.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I will sync it to crowdin

@jjw24
Copy link
Member

jjw24 commented Nov 22, 2021

before merging into dev, i want to squash all the commits into one. also get the other mr into here too

@taooceros
Copy link
Member Author

I will contact crowdin for the translation upload issue.

@taooceros taooceros closed this Nov 29, 2021
@taooceros taooceros force-pushed the add_crowdin_translations branch from 7d6c048 to d8773b8 Compare November 29, 2021 18:25
@taooceros taooceros reopened this Nov 29, 2021
@jjw24 jjw24 added the enhancement New feature or request label Dec 3, 2021
@jjw24 jjw24 added this to the 1.9.0 milestone Dec 3, 2021
@jjw24
Copy link
Member

jjw24 commented Dec 6, 2021

@taooceros @kubalav this should be good to merge into dev right? (let me merge it if it is)

@jjw24
Copy link
Member

jjw24 commented Dec 6, 2021

hey @kubalav how come your changes are not via Crowdin?

@kubalav
Copy link
Contributor

kubalav commented Dec 6, 2021

Edited and ready to merge.

@kubalav
Copy link
Contributor

kubalav commented Dec 6, 2021

hey @kubalav how come your changes are not via Crowdin?

I checked diff in Github and I didn't realize to make changes in Crowdin. Next time.

@jjw24
Copy link
Member

jjw24 commented Dec 6, 2021

no probs, was just curious

@jjw24 jjw24 merged commit 4affa2e into dev Dec 6, 2021
@jjw24 jjw24 deleted the add_crowdin_translations branch December 6, 2021 11:21
@jjw24 jjw24 restored the add_crowdin_translations branch December 6, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crowdin integration

4 participants