Skip to content

Conversation

@onesounds
Copy link
Contributor

image

WIP

  1. when you press f1, open preview area.
  2. you can see full file path and large size thumb.

Working on it. Pr for the test.

@onesounds
Copy link
Contributor Author

onesounds commented Oct 17, 2021

image

  • To use this function, empty query fix must be applied. If not, this will seem strange. You can test this version.https://ci.appveyor.com/project/JohnTheGr8/flow-launcher/builds/41173449/artifacts
  • preview toggle is F1 key. (I think this is the best shortcut.)
  • I can make it hidden when querybox empty, but I think It seems like a space that can be used. (some thing like start menu things) so I left it.
  • *lnk path function is related. If hiding lnk path, additional processing is required to show here.
  • Original image preview Addition should be considered.
  • it should be considered like a plug-in setting window.
  • When the size is flexible, when the item is changed while the preview is turned on, a distracting feeling remains. It might be better to get rid of the toggle method. (Instead, it can be changed to alt hold. it close when alt key up.)
  • Related style should also be added to the theme.

@taooceros
Copy link
Member

Do we want more description in the Preview feature?

@onesounds
Copy link
Contributor Author

Do we want more description in the Preview feature?

I don't need it anymore. how about you?
There is a possibility of a modify date, but it is difficult to put two(run, modify) like the initial design. It's very chaotic.
Let's leave it to the explorer for more information. 🗃️

@jjw24
Copy link
Member

jjw24 commented Nov 10, 2021

@onesounds is this ready to go? if so could we resolve conflict please

@onesounds
Copy link
Contributor Author

onesounds commented Nov 10, 2021

@onesounds is this ready to go? if so could we resolve conflict please

Not yet. This pr is a rough version. Additional tasks such as preview and shortcut key modification are required.

@jjw24
Copy link
Member

jjw24 commented Nov 10, 2021

i have marked it as draft

@jjw24 jjw24 marked this pull request as draft November 10, 2021 20:42
@jjw24
Copy link
Member

jjw24 commented Nov 10, 2021

...It seems like a space that can be used. (some thing like start menu things) so I left it.

i like this idea, it would be nice if this space offers most used results, but i dont think we can achieve this in this pr because the current model does not persist results and loading results correctly with action context is also something that needs working out. But yeah great idea.

@jjw24
Copy link
Member

jjw24 commented Nov 15, 2021

hey @onesounds was there a discussion on to put the preview on top or to the side of the results? what's your opinion on the positioning of the preview window?

@onesounds
Copy link
Contributor Author

hey @onesounds was there a discussion on to put the preview on top or to the side of the results? what's your opinion on the positioning of the preview window?

There were no other opinions. CitizenDee said He wish he could always turn it on.

It is recommended that the default position be placed on the right. (like spotlight on mac) However, in that case, various problems such as window size and vertical size arise. Since I can't think of a neat way, I'll think more about this pr. We will work again after the problem of reducing the lnk path path and other design prs are organized.

@onesounds onesounds closed this Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Pause

Development

Successfully merging this pull request may close these issues.

3 participants