Skip to content

Conversation

@onesounds
Copy link
Contributor

@onesounds onesounds commented Oct 14, 2021

Issue

image

  • in modern theme PR (in 1.9 pre Release).
  • If the query box text is prolonged, it invades the icon area when On shadow of window in setting
  • This is because the window size varies depending on the shadow on/off.

Fix

  • Fixed Width Value for all themes have been removed.
  • I added padding as much as the icon area.
  • The size of the query box does not change regardless of the shadow.

image

Test

  • Enter a query that exceeds the window area.
  • change the state of window shadow.
  • Type long query again.

(This is due to the problem that the size of the window changes when the shadow is turned on.)
- remove all querybox/suggest querybox width of themes
- Add padding for Magnifying glass area
@taooceros
Copy link
Member

Wondering where do set width now?

@onesounds
Copy link
Contributor Author

Wondering where do set width now?

sry for my enlgish. I removed all querybox/suggest box width. it only need padding for icon. window size still changable using window border property

@taooceros
Copy link
Member

I am interested why shadow will change the width. Maybe there's some code there that change the width?

@onesounds
Copy link
Contributor Author

I am interested why shadow will change the width. Maybe there's some code there that change the width?

This is because shadow implementation is an old method. The shadow implementation method itself must be changed. Transparent themes are also related, so it is better to solve the problem with another pr. This pr itself is a little better in terms of the theme structure. (There is room for improvement in the future, but it is a bit difficult to fix it right away.)

@taooceros taooceros merged commit 8cb7cbb into Flow-Launcher:dev Oct 24, 2021
@jjw24 jjw24 added the bug Something isn't working label Oct 25, 2021
@jjw24 jjw24 changed the title Fix width of the query box varies depending on the shadow state of the window. Dev branch: Fix width of the query box varies depending on the shadow state of the window. Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants