Skip to content

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented May 23, 2020

  1. Folder plugin change action keyword window layout needs to be updated

  2. Settings' Hotkey tab add hotkey window layout needs update

#56

@jjw24 jjw24 added the bug Something isn't working label May 23, 2020
@jjw24 jjw24 self-assigned this May 23, 2020
@JohnTheGr8
Copy link
Member

@jjw24 I'm seeing a couple issues that could be addressed as part of this PR:

  1. The Current action keyword text is cut off. Example:

  1. The current keyword value is not updated in UI unless I change to another view and back. Example:

  1. I think the "Success" message after submitting the form can be removed.

  2. Closing the form by hitting Esc would also be nice

@JohnTheGr8 JohnTheGr8 linked an issue May 27, 2020 that may be closed by this pull request
@JohnTheGr8
Copy link
Member

@jjw24 is this ready?

@jjw24
Copy link
Member Author

jjw24 commented Jun 17, 2020

@jjw24 is this ready?

I havent done add hot key tab window and press Esc to cancel per your comment.

I will request review once pr is ready, otherwise it's still wip

Copy link
Member

@JohnTheGr8 JohnTheGr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the margins and the MaxWidth="100" from the line under the plugin description text. The max-width does not play well with translations.

Also, Query time and Init time do not update when you switch language unless you switch to a different plugin tab...

Here's a screenshot that demonstrates both:

image

@JohnTheGr8
Copy link
Member

@jjw24 also, I tested the appveyor build and using Escape to exit the change-action-keyword window does nothing.

@jjw24
Copy link
Member Author

jjw24 commented Jun 21, 2020

@jjw24 also, I tested the appveyor build and using Escape to exit the change-action-keyword window does nothing.

It was added to the change key in Hotkey tab. I will add it also for change ActionKeyword window too

@jjw24
Copy link
Member Author

jjw24 commented Jun 21, 2020

I think we should remove the margins and the MaxWidth="100" from the line under the plugin description text. The max-width does not play well with translations.

Also, Query time and Init time do not update when you switch language unless you switch to a different plugin tab...

Here's a screenshot that demonstrates both:

image

@JohnTheGr8 Good pick up. Sorted

Copy link
Member

@JohnTheGr8 JohnTheGr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the success translation key should not have been removed from the translation files, as it is being used in other places. Example:
image

@JohnTheGr8
Copy link
Member

It was added to the change key in Hotkey tab. I will add it also for change ActionKeyword window too

Gotcha, thank you... I realize I was vague in my first comment about this :|

@JohnTheGr8
Copy link
Member

@JohnTheGr8 Good pick up. Sorted

(Note to self:)
There's still a few quirks when using translations. It will be easier if I address them in a separate PR instead of taking the time to explain them here.

@jjw24
Copy link
Member Author

jjw24 commented Jun 22, 2020

the success translation key should not have been removed from the translation files, as it is being used in other places. Example:
image

readded, good review @JohnTheGr8

@jjw24 jjw24 requested review from JohnTheGr8 and removed request for NickSeagull June 23, 2020 11:17
@JohnTheGr8 JohnTheGr8 merged commit a3374f2 into dev Jun 23, 2020
@jjw24 jjw24 deleted the update_uI_hotkey_actionkeyword branch June 24, 2020 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update UIs missed

3 participants