-
-
Notifications
You must be signed in to change notification settings - Fork 457
Update ActionKeyword window #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jjw24 I'm seeing a couple issues that could be addressed as part of this PR:
|
|
@jjw24 is this ready? |
I havent done add hot key tab window and press Esc to cancel per your comment. I will request review once pr is ready, otherwise it's still wip |
JohnTheGr8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the margins and the MaxWidth="100" from the line under the plugin description text. The max-width does not play well with translations.
Also, Query time and Init time do not update when you switch language unless you switch to a different plugin tab...
Here's a screenshot that demonstrates both:
|
@jjw24 also, I tested the appveyor build and using Escape to exit the change-action-keyword window does nothing. |
It was added to the change key in Hotkey tab. I will add it also for change ActionKeyword window too |
@JohnTheGr8 Good pick up. Sorted |
JohnTheGr8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, thank you... I realize I was vague in my first comment about this :| |
(Note to self:) |
readded, good review @JohnTheGr8 |




Folder plugin change action keyword window layout needs to be updated
Settings' Hotkey tab add hotkey window layout needs update
#56