fix Custom Plugin Hotkey not deselect text #570
Conversation
… custom plugin hotkey
| private void OnTextChanged(object sender, TextChangedEventArgs e) | ||
| private void MoveQueryTextToEnd() | ||
| { | ||
| if (_viewModel.QueryTextCursorMovedToEnd) | ||
| { | ||
| QueryTextBox.CaretIndex = QueryTextBox.Text.Length; | ||
| _viewModel.QueryTextCursorMovedToEnd = false; | ||
| } |
There was a problem hiding this comment.
We can add this once we want to do something else when text changed, but currently it would be better to call it when the property changed.
| { | ||
| QueryTextCursorMovedToEnd = true; | ||
| QueryText = queryText; | ||
| QueryTextCursorMovedToEnd = true; |
There was a problem hiding this comment.
change order to avoid unintended position changed before the QueryText Changed
Does this happen in dev branch? I remmeber I checked that custom query plugin hotkey doesn't select all text |
It does. It didn't select all text, but if the text is already selected, Flow is not able to deselect it. |
|
Oh ok. After this goes in we should be good to release 1.8.0 right? |
fix Custom Plugin Hotkey not deselect text when current query text is equal to custom plugin hotkey.
The part I describe in #565.