-
-
Notifications
You must be signed in to change notification settings - Fork 455
Json rpc unit test #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json rpc unit test #562
Conversation
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Folder Include="Properties\" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this removal intended? we still specify compile include at line 48 of the core csproj file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check. I don't know why this is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice addition, we should add more tests in general.
for unit tests, could we follow the GivenWhenThen structure please:
https://martinfowler.com/bliki/GivenWhenThen.html
Have a look at the stringmatcher unit tests as an example
|
I removed the unused InternalVisibleTo for Flow.Launcher project. We can add it when it's actually used |
Unit Test for JsonRPCPlugins