Skip to content

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented Jul 5, 2021

Unit Test for JsonRPCPlugins

  1. Check whether specific return string is parsed correctly
  2. Check whether case is actually insensitive

@taooceros taooceros added the enhancement New feature or request label Jul 5, 2021
</ItemGroup>

<ItemGroup>
<Folder Include="Properties\" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this removal intended? we still specify compile include at line 48 of the core csproj file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check. I don't know why this is removed.

Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice addition, we should add more tests in general.

for unit tests, could we follow the GivenWhenThen structure please:
https://martinfowler.com/bliki/GivenWhenThen.html

Have a look at the stringmatcher unit tests as an example

@jjw24
Copy link
Member

jjw24 commented Jul 7, 2021

I removed the unused InternalVisibleTo for Flow.Launcher project. We can add it when it's actually used

@jjw24 jjw24 enabled auto-merge July 7, 2021 23:25
@jjw24 jjw24 merged commit b39d21c into Flow-Launcher:dev Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants