Fix Explorer unexpected action keyword for folder index search #541
Conversation
| Action = c => | ||
| { | ||
| if (c.SpecialKeyState.CtrlPressed) | ||
| if (c.SpecialKeyState.CtrlPressed || !(Settings.EnabledPathSearchKeyword || Settings.EnableSearchActionKeyword)) |
There was a problem hiding this comment.
Is this saying both Settings.EnabledPathSearchKeyword and Settings.EnableSearchActionKeyword evaluate to false? Can we not just do (!Settings.EnabledPathSearchKeyword && !Settings.EnabledSearchActionKeyword) ?
There was a problem hiding this comment.
If we change it to Enabled, what about move Enabled to the end of the name, like PathSearchKeywordEnabled?
There was a problem hiding this comment.
Is this saying both Settings.EnabledPathSearchKeyword and Settings.EnableSearchActionKeyword evaluate to false? Can we not just do (!Settings.EnabledPathSearchKeyword && !Settings.EnabledSearchActionKeyword) ?
That will have two !🤣, but it seems more clear. I will change it.
There was a problem hiding this comment.
If we change it to Enabled, what about move Enabled to the end of the name, like PathSearchKeywordEnabled?
Sorry for the late reply, I am ok moving Enabled to the end if you want to
taooceros
added
bug
| Context.API.ChangeQuery(string.IsNullOrEmpty(query.ActionKeyword) ? | ||
| changeTo : | ||
| query.ActionKeyword + " " + changeTo); | ||
| Context.API.ChangeQuery($"{keyword}{changeTo}"); |
There was a problem hiding this comment.
You removed the space here, is it meant to be added to line 47?
There was a problem hiding this comment.
Yes, it is supposed to be a space instead of empty string. Will fix it soom.
|
Sorry, one more change, could we fix the typo for these To: |
i am got this, i am in front of comp now |
|
Sorry I was doing something else in the past hour🤣. |
|
nah all good, no probs |
2 participants
fix #539