Skip to content

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented May 18, 2020

Dev build runtime start up failure when %userprofile%\.nuget\packages\propertychanged.fody folder is deleted:
"
Description: A .NET Core application failed.
Application: Flow.Launcher.exe
Path: C:\Users\Blah\AppData\Local\Flow\app-1.0.0\Flow.Launcher.exe
Message: Error:
An assembly specified in the application dependencies manifest (Flow.Launcher.deps.json) was not found:
package: 'PropertyChanged.Fody', version: '3.2.8'
path: 'lib/netstandard1.0/PropertyChanged.dll'
"

Reduce the PropertyChange.Fody version.

@jjw24 jjw24 added the bug Something isn't working label May 18, 2020
@jjw24 jjw24 requested a review from JohnTheGr8 May 18, 2020 04:13
@jjw24 jjw24 self-assigned this May 18, 2020
@jjw24
Copy link
Member Author

jjw24 commented May 18, 2020

Just putting out a temporary prerelease so it's not broken, while this is under review.

@JohnTheGr8
Copy link
Member

@jjw24 do we actually use PropertyChanged.Fody?

I don't see any uses of INotifyPropertyChanged or the AddINotifyPropertyChangedInterface Attribute anywhere, except in Flow.Launcher.Plugin/BaseModel.cs... but this file is modified because of JetBrains.Annotations.

I have looked into the compiled dll with and without PropertyChanged.Fody and cannot notice any difference.

@JohnTheGr8
Copy link
Member

That said, I have been trying the various versions of PropertyChanged.Fody and noticed that version 2.5.13 is the latest version that does not cause runtime errors...

@jjw24
Copy link
Member Author

jjw24 commented May 18, 2020

@JohnTheGr8 happy to remove if not used, there are bits of code that are left overs which I am keen to get rid off. I will have a play without PropertyChanged.Fody and put in a commit if via to do so.

@JohnTheGr8
Copy link
Member

the package has been downgraded to 2.5.13 in #35

@JohnTheGr8 JohnTheGr8 closed this May 21, 2020
@jjw24 jjw24 deleted the fix_propertychangefody branch June 12, 2020 12:07
@jjw24 jjw24 mentioned this pull request Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants