Skip to content

[UI] Fix Settings-window doesn't show back up when minimized in taskbar by user #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2021
Merged

[UI] Fix Settings-window doesn't show back up when minimized in taskbar by user #484

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3384bf
[UI] Fix `Settings-window` doesn't show back up when minimized in tas…
pc223 Jun 22, 2021
43257ea
Remove .Activate()
pc223 Jun 22, 2021
18b889c
Remove empty lines
pc223 Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Flow.Launcher/Helper/SingletonWindowOpener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,16 @@ public static T Open<T>(params object[] args) where T : Window
var window = Application.Current.Windows.OfType<Window>().FirstOrDefault(x => x.GetType() == typeof(T))
?? (T)Activator.CreateInstance(typeof(T), args);
Application.Current.MainWindow.Hide();

// Fix UI bug
// Add `window.WindowState = WindowState.Normal`
// If only use `window.Show()`, Settings-window doesn't show when minimized in taskbar
// Not sure why this works tho
// Probably because, when `.Show()` fails, `window.WindowState == Minimized` (not `Normal`)
// https://stackoverflow.com/a/59719760/4230390
window.WindowState = WindowState.Normal;
window.Show();

window.Focus();

return (T)window;
Expand Down