Skip to content

Add backwards compatibility for Everything plugin v1.4.9 #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 21, 2021
Merged

Add backwards compatibility for Everything plugin v1.4.9 #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7319133
add backwards compatibility with Everything plugin
jjw24 Jun 21, 2021
6ec151a
use inheritance for ISavable and JsonStrorage
jjw24 Jun 21, 2021
0387bfb
update class name
jjw24 Jun 21, 2021
644be79
use ISavable and add obsolete message
jjw24 Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Flow.Launcher.Core/Plugin/PluginManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
using System.Threading.Tasks;
using Flow.Launcher.Infrastructure;
using Flow.Launcher.Infrastructure.Logger;
using Flow.Launcher.Infrastructure.Storage;
using Flow.Launcher.Infrastructure.UserSettings;
using Flow.Launcher.Plugin;
using ISavable = Flow.Launcher.Plugin.ISavable;

namespace Flow.Launcher.Core.Plugin
{
Expand Down Expand Up @@ -51,6 +51,7 @@ public static void Save()
var savable = plugin.Plugin as ISavable;
savable?.Save();
}

API.SavePluginSettings();
}

Expand Down
8 changes: 8 additions & 0 deletions Flow.Launcher.Infrastructure/Storage/ISavable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
using System;

namespace Flow.Launcher.Infrastructure.Storage
{
[Obsolete("Deprecated as of Flow Launcher v1.8.0, on 2021.06.21. " +
"This is used only for Everything plugin v1.4.9 or below backwards compatibility")]
public interface ISavable : Plugin.ISavable { }
}
4 changes: 4 additions & 0 deletions Flow.Launcher.Infrastructure/Storage/JsonStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,8 @@ public void Save()
File.WriteAllText(FilePath, serialized);
}
}

[Obsolete("Deprecated as of Flow Launcher v1.8.0, on 2021.06.21. " +
"This is used only for Everything plugin v1.4.9 or below backwards compatibility")]
public class JsonStrorage<T> : JsonStorage<T> where T : new() { }
}
1 change: 1 addition & 0 deletions Flow.Launcher.Infrastructure/Storage/PluginJsonStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,4 @@ public PluginJsonStorage(T data) : this()
}
}
}

1 change: 1 addition & 0 deletions Flow.Launcher/ViewModel/MainViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
using Flow.Launcher.Storage;
using Flow.Launcher.Infrastructure.Logger;
using System.Threading.Channels;
using ISavable = Flow.Launcher.Plugin.ISavable;

namespace Flow.Launcher.ViewModel
{
Expand Down