fix storyboard animation control error #474
Conversation
taooceros
changed the title
|
In Sysinternal Process explorer, after hiding, the cpu will be lower than 0.01. I believe that's acceptable. |
|
Also have you tested it still stops when hidden and starts again when visible as per the original behaviour? |
Yes, I have tested hide and start a few times, and also triggering progress bar animation by requesting suggestion source. However, let me test more about whether the animation is working properly. |
|
A small issue is that the progress bar animation will start at the position it stop last time. Should we reset the position? |
|
This is the query window re-appearing after hiding and query is still running? Then yeah I think resetting it is fine. |
2. Use begin/stop instead of resume/pause to reset position 3. Add a small delay when stopping the animation after hiding to make the animation more fluently
| }, System.Windows.Threading.DispatcherPriority.Render); | ||
| if (_viewModel.ProgressBarVisibility == Visibility.Hidden && !isProgressBarStoryboardPaused) | ||
| { | ||
| await Task.Delay(50); |
There was a problem hiding this comment.
make it stop after hiding, or else user may feel a bit stunt.
|
hmmm hold on, after the last commit it seems that flow will still consume some cpu cycle when hiding. Let me take another check. |
|
ok fixed |
2 participants
The storyboard is only able to be controlled if using Begin(object, controllable) for beginning.
Maybe this can actually drop cpu usage to 0.
Related to #128