Skip to content

change sequence of loading for shell plugin to avoid null reference #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2021
Merged

change sequence of loading for shell plugin to avoid null reference #460

merged 2 commits into from
Jun 4, 2021

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented Jun 3, 2021

fix a bug that setting hasn't been initialized but was accessed

@taooceros taooceros requested a review from jjw24 June 3, 2021 06:46
@taooceros taooceros self-assigned this Jun 4, 2021
@taooceros taooceros added the bug Something isn't working label Jun 4, 2021
@jjw24 jjw24 enabled auto-merge June 4, 2021 09:23
@jjw24 jjw24 mentioned this pull request Jun 4, 2021
Merged
@jjw24 jjw24 merged commit 04536c4 into dev Jun 4, 2021
@jjw24 jjw24 deleted the fixShellKeywordError branch June 4, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjw24 jjw24 jjw24 approved these changes

Assignees

@taooceros taooceros

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taooceros @jjw24