fix duplicate query searches from same global action keywords #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
why not just make GlobalPlugins a hashset? that can also fix sometimes people trying to add global actionkeyword twice. |
Use HashSet instead of List to avoid duplicate global plugin
Member
|
I finish the edit for HashSet because I would like to make some further change based on this branch. I found that await Task.Yield won't actually run task in threadpool, so maybe we shouldn't use it here. |
Member
Author
|
lgtm, did you want to approve? |
Member
|
Sorry I am reinstalling windows today. Will do it now |
taooceros
approved these changes
May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a plugin has multiple global action keywords, flow loops through the plugin's global (
*) and action keywords and fire them off to query. This creates a scenario where a plugin with multiple global action keywords (*), for example 4, running the plugin search 4 times unnecessarily. This also could potentially have a performance cost to it.This fix excludes adding multiple duplicate global and action keywords even if the plugin has 4 global action keywords, only fire search once.