Skip to content

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented May 14, 2021

close #413 close #421

@taooceros
Copy link
Member Author

By the way, I don't understand the autocomplete feature in the shell plugin. Why do people want to autocomplete a path in shell plugin? It only works when the whole command is a path.....

@jjw24
Copy link
Member

jjw24 commented May 16, 2021

it's like using cmd or ps window, you can tab to complete the path c:\pro to c:\program files, so you don't have to type out the entire path

@taooceros
Copy link
Member Author

taooceros commented May 16, 2021

it's like using cmd or ps window, you can tab to complete the path c:\pro to c:\program files, so you don't have to type out the entire path

but it only works for pure path. command like cd D:\ won't be able to autocomplete

Action = c =>
{
Execute(Process.Start, PrepareProcessStartInfo(m));
Execute(Process.Start, PrepareProcessStartInfo(m, c.SpecialKeyState.CtrlPressed));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to do something with this keystate right, passing it in is not going to start the shell as admin right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the CtrlPressed is a bool (when ctrl is pressed, it is true), and this parameter is starting as admin?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oohh ok, i didnt look at the method properly. cool

@jjw24
Copy link
Member

jjw24 commented May 16, 2021

it's like using cmd or ps window, you can tab to complete the path c:\pro to c:\program files, so you don't have to type out the entire path

but it only works for pure path. command like cd D:\ won't be able to autocomplete

yeah so something like cd d:\prog then user tabs and becomes cd d:\program files\ or cd d:\programdata\ etc

@jjw24
Copy link
Member

jjw24 commented May 16, 2021

version bumps please

@taooceros
Copy link
Member Author

yeah so something like cd d:\prog then user tabs and becomes cd d:\program files\ or cd d:\programdata\ etc

yeah, I understand the concept, but the current auto complete feature seems uncomplete. I will try to fix it to allow auto complete when the last term is path.

@taooceros
Copy link
Member Author

version bumps please

Sure

@jjw24
Copy link
Member

jjw24 commented May 16, 2021

yeah so something like cd d:\prog then user tabs and becomes cd d:\program files\ or cd d:\programdata\ etc

yeah, I understand the concept, but the current auto complete feature seems uncomplete. I will try to fix it to allow auto complete when the last term is path.

when did we add autocomplete for shell? it was never there right. You mean the main program's autocomplete? yeah it doesnt really have the actual autocomplete capability, it's a sort of reflection of the current selected result.

@jjw24
Copy link
Member

jjw24 commented May 16, 2021

you don't really need auto complete for all plugins right, maybe explorer and shell can benefit, maybe just extend it for those plugins only?

@taooceros
Copy link
Member Author

you don't really need auto complete for all plugins right, maybe explorer and shell can benefit, maybe just extend it for those plugins only?

No, I just mean that the autocomplete for shell is not working perfectly. It only works for pure path like D:\ but not command with path cd D:\

@jjw24 jjw24 enabled auto-merge May 16, 2021 06:51
@jjw24
Copy link
Member

jjw24 commented May 16, 2021

i think the merge erased the bump

@jjw24 jjw24 added the enhancement New feature or request label May 16, 2021
@jjw24 jjw24 merged commit 7092263 into Flow-Launcher:dev May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ctrl enter/click open Plugin's url Run shell cmds as admin with ctrl

2 participants