-
-
Notifications
You must be signed in to change notification settings - Fork 455
Add special ctrl for Pluginsmanager and Shell plugin #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
By the way, I don't understand the autocomplete feature in the shell plugin. Why do people want to autocomplete a path in shell plugin? It only works when the whole command is a path..... |
|
it's like using cmd or ps window, you can tab to complete the path c:\pro to c:\program files, so you don't have to type out the entire path |
but it only works for pure path. command like |
| Action = c => | ||
| { | ||
| Execute(Process.Start, PrepareProcessStartInfo(m)); | ||
| Execute(Process.Start, PrepareProcessStartInfo(m, c.SpecialKeyState.CtrlPressed)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to do something with this keystate right, passing it in is not going to start the shell as admin right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the CtrlPressed is a bool (when ctrl is pressed, it is true), and this parameter is starting as admin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oohh ok, i didnt look at the method properly. cool
yeah so something like |
|
version bumps please |
yeah, I understand the concept, but the current auto complete feature seems uncomplete. I will try to fix it to allow auto complete when the last term is path. |
Sure |
when did we add autocomplete for shell? it was never there right. You mean the main program's autocomplete? yeah it doesnt really have the actual autocomplete capability, it's a sort of reflection of the current selected result. |
|
you don't really need auto complete for all plugins right, maybe explorer and shell can benefit, maybe just extend it for those plugins only? |
No, I just mean that the autocomplete for shell is not working perfectly. It only works for pure path like |
|
i think the merge erased the bump |
close #413 close #421