Bring Legacy records together #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taooceros
commented
Apr 19, 2021
| } | ||
| _historyItemsStorage.Save(); | ||
| _userSelectedRecordStorage.Save(); | ||
| _topMostRecordStorage.Save(); |
Member
Author
There was a problem hiding this comment.
I remove this because it will prevent flow to continue save the records once user hit "Save Settings"
taooceros
commented
Apr 19, 2021
Comment on lines
-816
to
+809
| result.Score += _userSelectedRecord.GetSelectedCount(result) * 5 + priorityScore; | ||
| result.Score += _userSelectedRecord.GetSelectedCount(result) + priorityScore; |
Member
Author
There was a problem hiding this comment.
This *5 has been changed to UserSelectedRecords. Old one will get 1 score everytime selected
taooceros
commented
Apr 19, 2021
| public Dictionary<int, int> records { get; private set; } | ||
| public Dictionary<int, int> recordsWithQuery { get; private set; } | ||
|
|
||
| [JsonInclude, JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] |
Member
Author
There was a problem hiding this comment.
This is used to remove it once transformed
taooceros
commented
Apr 19, 2021
| public UserSelectedRecord() | ||
| { | ||
| records = new Dictionary<int, int>(); | ||
| recordsWithQuery = new Dictionary<int, int>(); |
Member
Author
There was a problem hiding this comment.
Not sure whether this name is great......but we cannot use records as name since the legacy one is using it.
Member
|
Will take a look this weekend |
jjw24
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following on from #398
close #402