Skip to content

Conversation

@Jack251970
Copy link
Member

@Jack251970 Jack251970 commented Nov 18, 2025

Finish // TODO: Use IsScrollAnimationEnabled property in future: https://github.com/iNKORE-NET/UI.WPF.Modern/pull/347

Upgraded iNKORE.UI.WPF.Modern to version 0.10.2.1 and replaced the custom CustomScrollViewerEx implementation with the built-in ScrollViewerEx for simplified scrolling behavior. Updated Flow.Launcher.Plugin to version 5.1.0 for compatibility. Removed unused namespaces and adjusted styles in Base.xaml to align with the new ScrollViewerEx usage.

Follow on with #3593

Upgraded `iNKORE.UI.WPF.Modern` to version `0.10.2.1` and
replaced the custom `CustomScrollViewerEx` implementation with
the built-in `ScrollViewerEx` for simplified scrolling behavior.
Updated `Flow.Launcher.Plugin` to version `5.1.0` for compatibility.
Removed unused namespaces and adjusted styles in `Base.xaml`
to align with the new `ScrollViewerEx` usage.
@Jack251970 Jack251970 requested a review from Copilot November 18, 2025 14:19
@prlabeler prlabeler bot added Code Refactor enhancement New feature or request labels Nov 18, 2025
@github-actions github-actions bot added this to the 2.1.0 milestone Nov 18, 2025
@Jack251970 Jack251970 added Dev branch only An issue or fix for the Dev branch build and removed enhancement New feature or request labels Nov 18, 2025
@gitstream-cm
Copy link

gitstream-cm bot commented Nov 18, 2025

🥷 Code experts: onesounds

Jack251970 has most 👩‍💻 activity in the files.
Jack251970, onesounds have most 🧠 knowledge in the files.

See details

Flow.Launcher/Flow.Launcher.csproj

Activity based on git-commit:

Jack251970
NOV
OCT 2 additions & 4 deletions
SEP 50 additions & 44 deletions
AUG 101 additions & 56 deletions
JUL 7 additions & 8 deletions
JUN 5 additions & 0 deletions

Knowledge based on git-blame:
Jack251970: 35%
onesounds: 11%

Flow.Launcher/Themes/Base.xaml

Activity based on git-commit:

Jack251970
NOV
OCT 14 additions & 9 deletions
SEP
AUG
JUL
JUN

Knowledge based on git-blame:
onesounds: 69%
Jack251970: 3%

Flow.Launcher/packages.lock.json

Activity based on git-commit:

Jack251970
NOV
OCT 14 additions & 6 deletions
SEP 946 additions & 179 deletions
AUG 195 additions & 195 deletions
JUL 498 additions & 282 deletions
JUN

Knowledge based on git-blame:
Jack251970: 77%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

@gitstream-cm
Copy link

gitstream-cm bot commented Nov 18, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

@prlabeler prlabeler bot added the enhancement New feature or request label Nov 18, 2025
@gitstream-cm
Copy link

gitstream-cm bot commented Nov 18, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Copilot finished reviewing on behalf of Jack251970 November 18, 2025 14:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the iNKORE.UI.WPF.Modern library from version 0.10.1 to 0.10.2.1 and refactors the scrolling logic by replacing a custom CustomScrollViewerEx implementation with the library's built-in ScrollViewerEx control. The Flow.Launcher.Plugin version is also updated to 5.1.0 for compatibility.

Key Changes:

  • Upgraded iNKORE.UI.WPF.Modern from 0.10.1 to 0.10.2.1
  • Removed custom CustomScrollViewerEx class and replaced it with built-in ScrollViewerEx
  • Updated Flow.Launcher.Plugin dependency references from 5.0.0 to 5.1.0

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
Flow.Launcher/packages.lock.json Updated package lock file with new versions of iNKORE.UI.WPF.Modern (0.10.2.1) and Flow.Launcher.Plugin references (5.1.0)
Flow.Launcher/Flow.Launcher.csproj Updated iNKORE.UI.WPF.Modern package reference to version 0.10.2.1
Flow.Launcher/Themes/Base.xaml Replaced custom CustomScrollViewerEx control with library's ScrollViewerEx, added IsScrollAnimationEnabled and RewriteWheelChange properties, and updated corresponding style target types
Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs Removed entire custom scroll viewer implementation as it's now provided by the upgraded library

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Refactor Dev branch only An issue or fix for the Dev branch build enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants