-
-
Notifications
You must be signed in to change notification settings - Fork 457
Upgrade iNKORE.UI.WPF.Modern and refactor scroll logic #4118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Upgraded `iNKORE.UI.WPF.Modern` to version `0.10.2.1` and replaced the custom `CustomScrollViewerEx` implementation with the built-in `ScrollViewerEx` for simplified scrolling behavior. Updated `Flow.Launcher.Plugin` to version `5.1.0` for compatibility. Removed unused namespaces and adjusted styles in `Base.xaml` to align with the new `ScrollViewerEx` usage.
|
🥷 Code experts: onesounds Jack251970 has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the iNKORE.UI.WPF.Modern library from version 0.10.1 to 0.10.2.1 and refactors the scrolling logic by replacing a custom CustomScrollViewerEx implementation with the library's built-in ScrollViewerEx control. The Flow.Launcher.Plugin version is also updated to 5.1.0 for compatibility.
Key Changes:
- Upgraded
iNKORE.UI.WPF.Modernfrom 0.10.1 to 0.10.2.1 - Removed custom
CustomScrollViewerExclass and replaced it with built-inScrollViewerEx - Updated
Flow.Launcher.Plugindependency references from 5.0.0 to 5.1.0
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Flow.Launcher/packages.lock.json | Updated package lock file with new versions of iNKORE.UI.WPF.Modern (0.10.2.1) and Flow.Launcher.Plugin references (5.1.0) |
| Flow.Launcher/Flow.Launcher.csproj | Updated iNKORE.UI.WPF.Modern package reference to version 0.10.2.1 |
| Flow.Launcher/Themes/Base.xaml | Replaced custom CustomScrollViewerEx control with library's ScrollViewerEx, added IsScrollAnimationEnabled and RewriteWheelChange properties, and updated corresponding style target types |
| Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs | Removed entire custom scroll viewer implementation as it's now provided by the upgraded library |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Finish
// TODO: Use IsScrollAnimationEnabled property in future: https://github.com/iNKORE-NET/UI.WPF.Modern/pull/347Upgraded
iNKORE.UI.WPF.Modernto version0.10.2.1and replaced the customCustomScrollViewerEximplementation with the built-inScrollViewerExfor simplified scrolling behavior. UpdatedFlow.Launcher.Pluginto version5.1.0for compatibility. Removed unused namespaces and adjusted styles inBase.xamlto align with the newScrollViewerExusage.Follow on with #3593