-
-
Notifications
You must be signed in to change notification settings - Fork 455
Allow Quick Access Links to be accessed with middle string #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Given rest of search in Explorer can't use fuzzy, probably just stick with contains so not too confuse users? Instead of looping through the matched results again and update score, what about adding an optional score parameter to the create file and create folder methods and assign the score that way? |
I guess the rest of the search in Explorer still uses fuzzy to calculate the score.
Yeah that seems great,. |
Just to calculate score or also uses fuzzy? I'm afk so can't take a look... |
calculate the score as I remember previously. Let me take a look |
|
Update: it utilizes fuzzy to create highlighed data. |
|
Ok so actual search and score is not using fuzzy yeah |
|
Version bump also forgot to mention |
| else | ||
| { | ||
| fileResults.Add(ResultManager.CreateFileResult(path, query, true, true)); | ||
| fileResults.Add(ResultManager.CreateFileResult(path, query, 0, true, true)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we setting the score to 0 in several of the changes, have they always been 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we don't set the score before, which is default 0.
31c0fb0 to
1015177
Compare
|
Thanks, haven't got time to finish the version bump. |
Use
Containsinstead ofStartWithto allows search with middle part of name, also score bump to 100 since it is not a fuzzy, but a full matched.Or using Fuzzy would be better?