Skip to content

Conversation

@taooceros
Copy link
Member

Use Contains instead of StartWith to allows search with middle part of name, also score bump to 100 since it is not a fuzzy, but a full matched.

Or using Fuzzy would be better?

@taooceros taooceros requested a review from jjw24 April 13, 2021 11:15
@jjw24
Copy link
Member

jjw24 commented Apr 13, 2021

Given rest of search in Explorer can't use fuzzy, probably just stick with contains so not too confuse users?

Instead of looping through the matched results again and update score, what about adding an optional score parameter to the create file and create folder methods and assign the score that way?

@taooceros
Copy link
Member Author

Given rest of search in Explorer can't use fuzzy, probably just stick with contains so not too confuse users?

I guess the rest of the search in Explorer still uses fuzzy to calculate the score.

Instead of looping through the matched results again and update score, what about adding an optional score parameter to the create file and create folder methods and assign the score that way?

Yeah that seems great,.

@jjw24
Copy link
Member

jjw24 commented Apr 13, 2021

I guess the rest of the search in Explorer still uses fuzzy to calculate the score.

Just to calculate score or also uses fuzzy? I'm afk so can't take a look...

@taooceros
Copy link
Member Author

taooceros commented Apr 13, 2021

I guess the rest of the search in Explorer still uses fuzzy to calculate the score.

Just to calculate score or also uses fuzzy? I'm afk so can't take a look...

calculate the score as I remember previously. Let me take a look

@taooceros
Copy link
Member Author

taooceros commented Apr 13, 2021

Update: it utilizes fuzzy to create highlighed data.

@jjw24
Copy link
Member

jjw24 commented Apr 13, 2021

Ok so actual search and score is not using fuzzy yeah

@jjw24 jjw24 enabled auto-merge April 13, 2021 11:50
@jjw24 jjw24 added the bug Something isn't working label Apr 13, 2021
@jjw24
Copy link
Member

jjw24 commented Apr 13, 2021

Version bump also forgot to mention

else
{
fileResults.Add(ResultManager.CreateFileResult(path, query, true, true));
fileResults.Add(ResultManager.CreateFileResult(path, query, 0, true, true));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we setting the score to 0 in several of the changes, have they always been 0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we don't set the score before, which is default 0.

@jjw24 jjw24 force-pushed the changeConditionCheckForQuickAccessFolder branch from 31c0fb0 to 1015177 Compare April 13, 2021 22:50
@jjw24 jjw24 merged commit 888b44f into dev Apr 13, 2021
@jjw24 jjw24 deleted the changeConditionCheckForQuickAccessFolder branch April 13, 2021 23:09
@taooceros
Copy link
Member Author

Thanks, haven't got time to finish the version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants