Skip to content

Fix concurrent access issue #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2021
Merged

Fix concurrent access issue #407

merged 2 commits into from
Apr 14, 2021

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented Apr 12, 2021

fix #406

@taooceros
Copy link
Member Author

taooceros commented Apr 12, 2021

Hold on.... Let me rebase first

@taooceros taooceros force-pushed the fixConcurrentAccessIssue branch from 0fb435a to 78d8dbb Compare April 12, 2021 10:44
@taooceros taooceros requested a review from jjw24 April 12, 2021 10:45
@taooceros
Copy link
Member Author

taooceros commented Apr 12, 2021

By the way, I guess this is why I add a try catch for Program plugin.
image
It won't happen in release mode, but I don't understand why its error thrown has been early caught by debugger.

@jjw24 jjw24 added bug Something isn't working review in progress Indicates that a review is in progress for this PR labels Apr 12, 2021
@jjw24 jjw24 removed the review in progress Indicates that a review is in progress for this PR label Apr 14, 2021
@jjw24 jjw24 merged commit 0b0a185 into dev Apr 14, 2021
@jjw24 jjw24 deleted the fixConcurrentAccessIssue branch April 14, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjw24 jjw24 jjw24 approved these changes

Assignees

@taooceros taooceros

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dev branch: Error- Operation not legal

3 participants

@taooceros @jjw24