Skip to content

save Shell plugin cmd history #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 12, 2021
Merged

save Shell plugin cmd history #404

merged 6 commits into from
Apr 12, 2021

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented Apr 12, 2021 •
edited
Loading

  • Added saving executed cmds to settings
  • Added option to show 5, 10, 20 most used cmds in settings

close #403, #405

@jjw24 jjw24 added the enhancement New feature or request label Apr 12, 2021
@jjw24 jjw24 self-assigned this Apr 12, 2021
@jjw24 jjw24 marked this pull request as draft April 12, 2021 04:27
@jjw24 jjw24 marked this pull request as ready for review April 12, 2021 10:21
@jjw24 jjw24 enabled auto-merge April 12, 2021 10:22
@jjw24 jjw24 mentioned this pull request Apr 12, 2021
Merged
@taooceros
Copy link
Member

taooceros commented Apr 12, 2021 •
edited
Loading

is the default value for boolean false?

@jjw24
Copy link
Member Author

jjw24 commented Apr 12, 2021

Yep, that's why I didn't include default value.

@jjw24 jjw24 merged commit 256bfb7 into dev Apr 12, 2021
@jjw24 jjw24 deleted the save_shell_cmd_history branch April 12, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taooceros taooceros taooceros approved these changes

@gdziedzic gdziedzic Awaiting requested review from gdziedzic

@JohnTheGr8 JohnTheGr8 Awaiting requested review from JohnTheGr8

@SysC0mp SysC0mp Awaiting requested review from SysC0mp

Assignees

@jjw24 jjw24

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shell plugin cmd history does not get saved

3 participants

@jjw24 @taooceros