Increase the default width and allow user to resize setting window, and reduce the margin for PluginDirectory #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd reduce the margin for PluginDirectory modified: Flow.Launcher/SettingWindow.xaml modified: Flow.Launcher/SettingWindow.xaml
Member
|
Change looks good to me, I am afk and want to load up the change to have a look first before merging. |
Member
|
hmm pluginsmanager and program plugins are still a bit off, could you adjust a little bit more please:
|
Member
Author
|
@jjw24 done |
jjw24
approved these changes
Mar 30, 2021
Member
jjw24
left a comment
jjw24
left a comment
There was a problem hiding this comment.
👍
Hijacked your PR to do a quick update to translation and text, added a minwidth too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #375
I increase the default width. The issue is due to the added Priority option, which uses more width than expected. Also, I allow users to resize the window. I don't know why we stop user from doing it before.