Make PluginJsonStorage in IPublicAPI become single instance per type #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taooceros
force-pushed
the
PluginJsonStorageSingleInstance
branch
from
ccac0c0 to
6fe83d8
Compare
jjw24
approved these changes
Mar 31, 2021
Member
|
@taooceros what would be a scenario where you would use BackupJsonStorage? |
Member
Author
I don't know, but that is held in the JsonStroage class, so I add it as well. I guess if some plugin would like to use JsonStorage to store information that may change through usage, so backing up sometimes will make a record? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep align with the usage of JsonStorage that use an instance holding the data to load and save instead of creating a new one every time. It uses dynamic to fit the generic type, but I also see someone use a generic type with static class to achieve similar result, but that will change quite significantly.
#388