Make IPlugin inherit from IAsyncPlugin #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is going to force the plugins to implement Async? |
Member
Author
No, it is the same as the current behavior for IPlugin, which wraps a Task.Run with the Query method. |
jjw24
added
the
review in progress
jjw24
removed
the
review in progress
jjw24
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently separated interface create quite significant code duplicate, so I try making the old plugin interface extends from the new plugin interface with the default implementation of interface from c# 8. (This is similar to the first version of the new Async model which directly use the default implementation in IPlugin interface).
It is hard to say which choice is better🤔🤔🤔, but this prevents the weird empty default implementation in legacy Query method.