-
-
Notifications
You must be signed in to change notification settings - Fork 456
Optimize startup #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize startup #389
Conversation
|
Oops, let me fix the build fail. |
|
version bumps as well please |
|
@taooceros need to also bump bookmarks plugin version. Does removing readonly improve anything? I don't remember, remind me again what's the benefit of using enumerate over get for directories? |
jjw24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
No, but readonly requires initialization in constructor, while we construct instance in sync. I move that to Init() to allow parallel initialization. |
Sorry I miss this question. It will be faster because we don't need to wait the enumeration finish to create an array, but can do what we want as the enumeration going. GetDirectories/GetFiles will return an array, while enumerateDirectories will return an IEnumerable. |
A few enhancement I found during the investigation of #371