Skip to content

Conversation

@taooceros
Copy link
Member

A few enhancement I found during the investigation of #371

@jjw24 jjw24 added the bug Something isn't working label Mar 18, 2021
@taooceros
Copy link
Member Author

Oops, let me fix the build fail.

@jjw24
Copy link
Member

jjw24 commented Mar 18, 2021

version bumps as well please

@jjw24 jjw24 enabled auto-merge March 18, 2021 18:31
@taooceros taooceros requested a review from jjw24 March 21, 2021 08:05
@jjw24
Copy link
Member

jjw24 commented Mar 21, 2021

@taooceros need to also bump bookmarks plugin version.

Does removing readonly improve anything?

I don't remember, remind me again what's the benefit of using enumerate over get for directories?

Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@taooceros
Copy link
Member Author

@taooceros need to also bump bookmarks plugin version.

Does removing readonly improve anything?

I don't remember, remind me again what's the benefit of using enumerate over get for directories?

No, but readonly requires initialization in constructor, while we construct instance in sync. I move that to Init() to allow parallel initialization.

@jjw24 jjw24 merged commit b5e54a7 into dev Mar 21, 2021
@jjw24 jjw24 deleted the optimizeStartup branch March 21, 2021 18:08
@taooceros
Copy link
Member Author

taooceros commented Mar 22, 2021

I don't remember, remind me again what's the benefit of using enumerate over get for directories?

Sorry I miss this question. It will be faster because we don't need to wait the enumeration finish to create an array, but can do what we want as the enumeration going. GetDirectories/GetFiles will return an array, while enumerateDirectories will return an IEnumerable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants