Skip to content

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented Feb 28, 2021

  1. Since web searches is performed many times, let's change the default to global action keyword so first time users do not need to go hunting in settings to find out the action keyword to activate it.

  2. Update so if a action keyword is matched, display on top of global action keyword ('*')
    before:
    image

after:
image

suggestions also follow the same format.

@jjw24 jjw24 added the bug Something isn't working label Feb 28, 2021
@jjw24 jjw24 self-assigned this Feb 28, 2021
@jjw24 jjw24 enabled auto-merge February 28, 2021 20:53
@taooceros
Copy link
Member

There's an issue for changing one to global keyword, that when you want to use action keyword for other source, this one will appear still. (and search suggestions will be duplicate maybe)
Maybe we still need to disable the global source when query with special keyword.

@taooceros
Copy link
Member

Maybe we can change the suggestion source to not directly search, but change query to specific suggestion to avoid duplicate suggestion for different source.

@jjw24
Copy link
Member Author

jjw24 commented Mar 1, 2021

Well because it's using global and it's searching whatever you have typed in, therefore results from it will show up, this behaviour is normal, it's not broken. We should probably improve it by if there is an action keyword matched with another source, then show the results from that action keyword above the result from global action keyword, ie results from github search after typing github flow is above results from google search

@jjw24 jjw24 requested review from taooceros and removed request for taooceros March 1, 2021 09:28
@taooceros
Copy link
Member

Well because it's using global and it's searching whatever you have typed in, therefore results from it will show up, this behaviour is normal, it's not broken. We should probably improve it by if there is an action keyword matched with another source, then show the results from that action keyword above the result from global action keyword, ie results from github search after typing github flow is above results from google search

Well, the main issue I am concerning about is the suggestion source. Currently that is not supporting multiple suggestion source.
And the order addressing that should be changed (or else one suggestion source will need to wait till the suggestion source complete to show up).

@jjw24
Copy link
Member Author

jjw24 commented Mar 1, 2021

Well because it's using global and it's searching whatever you have typed in, therefore results from it will show up, this behaviour is normal, it's not broken. We should probably improve it by if there is an action keyword matched with another source, then show the results from that action keyword above the result from global action keyword, ie results from github search after typing github flow is above results from google search

Well, the main issue I am concerning about is the suggestion source. Currently that is not supporting multiple suggestion source.
And the order addressing that should be changed (or else one suggestion source will need to wait till the suggestion source complete to show up).

multi source suggestion seems to be working fine, it's in the foreach loop:
image

@taooceros
Copy link
Member

Well because it's using global and it's searching whatever you have typed in, therefore results from it will show up, this behaviour is normal, it's not broken. We should probably improve it by if there is an action keyword matched with another source, then show the results from that action keyword above the result from global action keyword, ie results from github search after typing github flow is above results from google search

Well, the main issue I am concerning about is the suggestion source. Currently that is not supporting multiple suggestion source.
And the order addressing that should be changed (or else one suggestion source will need to wait till the suggestion source complete to show up).

multi source suggestion seems to be working fine, it's in the foreach loop:
image

Oh I thought I haven't changed that on the earlier commit. Never mind, and it seems work great!

@jjw24 jjw24 merged commit f927702 into dev Mar 1, 2021
@jjw24 jjw24 deleted the change_websearch_default branch March 1, 2021 12:44
@jjw24 jjw24 changed the title Change WebSearch default to global Change WebSearch default to global and update result ordering Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants