Fix command issue for pswh.exe

[Jack251970]

Follow on with #3225. Resolve #3654.

[gitstream-cm]

🥷 Code experts: no user but you matched threshold 10

Jack251970, onesounds have most 👩‍💻 activity in the files.
jjw24 has most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.Shell/Main.cs

Activity based on git-commit:

	Jack251970	onesounds
JUN
MAY	6 additions & 3 deletions	5 additions & 2 deletions
APR	34 additions & 29 deletions
MAR
FEB	3 additions & 4 deletions
JAN

Knowledge based on git-blame:
jjw24: 13%

To learn more about /:\ gitStream - Visit our Docs

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

📝 Walkthrough

Walkthrough

The change updates the command argument construction for PowerShell Core (pwsh) in the Shell plugin. It conditionally adds a backslash before the semicolon delimiter only when using Windows Terminal, preventing erroneous backslash characters from being appended to commands in other contexts.

Changes

File(s)	Change Summary
Plugins/Flow.Launcher.Plugin.Shell/Main.cs	Modified PrepareProcessStartInfo to conditionally add a backslash before semicolon only for Windows Terminal, correcting command parsing issues.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ShellPlugin
    participant Terminal

    User->>ShellPlugin: Execute command via Shell plugin
    ShellPlugin->>ShellPlugin: PrepareProcessStartInfo()
    alt UseWindowsTerminal is true
        ShellPlugin->>ShellPlugin: Add backslash before semicolon
    else UseWindowsTerminal is false
        ShellPlugin->>ShellPlugin: No backslash added
    end
    ShellPlugin->>Terminal: Start process with constructed command

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Fix Shell plugin so that a backslash is not erroneously appended to commands (e.g., scoop update\) except when required for Windows Terminal (#3654)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Suggested labels

Dev branch only

Suggested reviewers

• onesounds

Poem

A backslash here, a semicolon there,
Shell commands now run with flair!
Windows Terminal gets its due,
No stray slashes to misconstrue.
Bugs squashed quick, as rabbits hop—
This fix will make the errors stop! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2e754d and d7c7ec8.

📒 Files selected for processing (1)

• Plugins/Flow.Launcher.Plugin.Shell/Main.cs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• Plugins/Flow.Launcher.Plugin.Shell/Main.cs

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: gitStream workflow automation
• GitHub Check: gitStream.cm
• GitHub Check: build
• GitHub Check: Check Spelling

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This PR addresses the command issue for pswh.exe by modifying how command strings are built, particularly for Windows Terminal scenarios. Key changes include introducing an escape sequence variable for handling semicolon conflicts and updating command string interpolation in both Powershell and Pwsh cases.

Comments suppressed due to low confidence (2)

Plugins/Flow.Launcher.Plugin.Shell/Main.cs:223

• [nitpick] The variable name 'addedCharacter' might be ambiguous regarding its purpose. Consider renaming it to 'escapeSequence' to better convey that it holds the escape characters.

var addedCharacter = _settings.UseWindowsTerminal ? "\" : "";

Plugins/Flow.Launcher.Plugin.Shell/Main.cs:250

• [nitpick] The same variable 'addedCharacter' is defined here; renaming it to 'escapeSequence' across both cases would improve clarity and maintain consistency.

var addedCharacter = _settings.UseWindowsTerminal ? "\" : "";

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings	Count
❌ forbidden-pattern	22
⚠️ non-alpha-in-dictionary	13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.