Catch and prompt user when installing Everything is unsuccessful #3655
Conversation
|
🥷 Code experts: no user but you matched threshold 10 Jack251970 has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
📝 WalkthroughWalkthroughThis change adds two new localized error messages to the English resource file for the Everything plugin and refactors the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant EverythingSearchManager
participant Settings
participant Logger
participant UI
User->>EverythingSearchManager: ClickToInstallEverythingAsync()
EverythingSearchManager->>EverythingSearchManager: Try installation logic
alt Installation path is null
EverythingSearchManager->>UI: Show "Everything.exe not found" error
EverythingSearchManager->>Logger: Log error with class name
EverythingSearchManager-->>User: Return false
else Installation path is valid
EverythingSearchManager->>Settings: Update with installed path
EverythingSearchManager->>Everything.exe: Start process with "-startup"
EverythingSearchManager-->>User: Return true
end
alt Exception occurs
EverythingSearchManager->>UI: Show "Installation issue" error
EverythingSearchManager->>Logger: Log exception with class name
EverythingSearchManager-->>User: Return false
end
Assessment against linked issues
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (4)
🔇 Additional comments (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR improves the error handling for the Everything installation process by catching installation exceptions and informing the user appropriately.
- Added a try-catch block in ClickToInstallEverythingAsync to intercept installation failures.
- Updated language resource file with new translation keys for error messages.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingSearchManager.cs | Added try-catch around Everything installation logic and enhanced error reporting. |
| Plugins/Flow.Launcher.Plugin.Explorer/Languages/en.xaml | Added translation keys for error messages related to Everything installation issues. |
Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingSearchManager.cs
Show resolved
Hide resolved
jjw24
changed the title
jjw24
changed the title
Sometimes Everything installation will fail because of permission issues or file not found issues, so we should let the user know that Everything is not installed properly and ask them to install it manually.
Resolve #3184, #3381, #3393.