-
-
Notifications
You must be signed in to change notification settings - Fork 455
change taskcanceledexception to operationcanceledexception #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I originally think that taskcancelledexception may be thrown by task cancellation token, but in reality it throws an operation canceledexception. |
Do we need to update websearch too?
Sounds strange, how are we going to differentiate task cancelled and actual error from operation cancelled? |
|
I just read some new change toward HttpClient, and they seems not wrap a Timeout exception within the TaskCanceledException. Our original OperationCanceledException is for one excpetion handling for both taskcanceledexception and parallel exercution canceled exception. |
|
Based on the discussion there and the pr, we should distinguish this by checking whether innerexception is timeoutexception. |
|
emmm seems that that pr is for .Net 5, so we can only do that after upgrading to .net 5 |
jjw24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we get more users reporting this issue, then we can do a hotfix
fix #357