Fix http error #361
Fix http error #361
Conversation
|
Todo: move http proxy initialization earlier before plugin initialization. |
|
is this ready to go? @taooceros |
Let me finish this first. I just get my computer. |
|
Done, please review @jjw24 |
Flow.Launcher/App.xaml.cs
Outdated
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
lol you love your spaces dont you 😛
There was a problem hiding this comment.
ah 🤣🤣🤣 I love to separate different parts of code doing different with spaces🤣🤣🤣
Flow.Launcher.Test/HttpTest.cs
Outdated
| class HttpTest | ||
| { | ||
| [Test] | ||
| public void TestSettingUpdate() |
There was a problem hiding this comment.
can you give this a bit more description please, Given-When-Then
There was a problem hiding this comment.
ok, I will add comment.
There was a problem hiding this comment.
hey if it's ok, i will update it for you, sorry i need to be afk soon and i want to get this release ready, so when you are free have a look at 1.7.2 and approve if all good, i will release it later
There was a problem hiding this comment.
Yeah sure, if you would like to do it, it will be great. I just have dinner so haven't finish that part.
There was a problem hiding this comment.
I will approve 1.7.2 once this has been merged. 🥰
2 participants
fix #354