add taskcanceledexception to updater exception catch #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
just changed it to avoid logging |
jjw24
previously approved these changes
Feb 21, 2021
Member
Author
|
Hold on, we should keep taskcancelledexception with log, because it means timeout. |
Member
|
oh ok right |
Member
|
lets release a hotfix to master as well, this issue is going to be experienced by users with auto update on |
jjw24
force-pushed
the
fixErrorHandlingInUpdater
branch
from
4ee47f1 to
2f9d4d1
Compare
jjw24
approved these changes
Feb 21, 2021
Member
Author
|
Remember to bump the version so that it will be downloaded automatically by user(although I think user with this issue may be hard to auto update). |
Member
|
yeah true... |
Merged
Member
Author
|
Hmmm sorry that seems I add the wrong issue handling....... It seems that the actual error that has been thrown is operationcanceledexception..... |
Member
|
All good. Let's fix it up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #357
This may because HttpClient throws TaskCanceledException when timeout instead of HttpException, which is previously thrown by the old HttpWebRequest.