Remove unused check for Stream length #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
is this referring to throwing cancellation token exceptions? |
Member
Author
I believe, but not quite sure. |
jjw24
reviewed
Feb 16, 2021
Plugins/Flow.Launcher.Plugin.WebSearch/SuggestionSources/Google.cs
Outdated
Show resolved
Hide resolved
jjw24
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #345
The cancellation process is done by HttpClient natively by throwing TaskCancelledException, so no need to check the Stream length for that.
Seems that throwing exceptions makes the programs runs really slow in debug mode? Not quite sure for that.