Remove setting after uninstalling plugin #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjw24
reviewed
Feb 13, 2021
jjw24
reviewed
Feb 13, 2021
|
|
||
|
|
||
| Core.Plugin.PluginManager.Settings.Plugins.Remove(plugin.ID); | ||
| Core.Plugin.PluginManager.AllPlugins.RemoveAll(p => p.Metadata.ID == plugin.ID); |
Member
There was a problem hiding this comment.
if we can do this, does this mean no restart is required?
Member
Author
There was a problem hiding this comment.
Well, we still cannot unload assembly unless we use the library @JohnTheGr8 has mentioned, but we can load assembly dynamically, which means that installation may not require restart.
Member
|
This is ready for review? |
Member
Author
yes, it is a simple change and it works |
jjw24
approved these changes
Feb 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #265
TODO:
create an interface for cleaning up plugin information if they store setting or some data.