Fix untranslated string #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjw24
reviewed
Jan 24, 2021
Comment on lines
22
to
38
| <ColumnDefinition Width="150" /> | ||
| <ColumnDefinition Width="102.124" /> | ||
| <ColumnDefinition Width="47.876"/> | ||
| <ColumnDefinition /> | ||
| </Grid.ColumnDefinitions> | ||
| <TextBlock Margin="10" FontSize="14" Grid.Row="0" Grid.Column="0" VerticalAlignment="Center" | ||
| HorizontalAlignment="Right" Text="{DynamicResource hotkey}" /> | ||
| <flowlauncher:HotkeyControl x:Name="ctlHotkey" Margin="10,0,10,0" Grid.Column="1" VerticalAlignment="Center" Height="32" /> | ||
| <TextBlock Margin="92,0,0,0" FontSize="14" Grid.Column="0" VerticalAlignment="Center" | ||
| HorizontalAlignment="Left" Text="{DynamicResource hotkey}" Grid.ColumnSpan="2" /> | ||
| <flowlauncher:HotkeyControl x:Name="ctlHotkey" Margin="10,0,10,0" Grid.Column="2" VerticalAlignment="Center" Height="32" /> | ||
|
|
||
| <TextBlock Margin="10" FontSize="14" Grid.Row="1" Grid.Column="0" VerticalAlignment="Center" | ||
| HorizontalAlignment="Right" Text="{DynamicResource actionKeyword}" /> | ||
| <StackPanel Grid.Row="1" Orientation="Horizontal" Grid.Column="1"> | ||
| <TextBlock Margin="38,0,0,0" FontSize="14" Grid.Row="1" Grid.Column="1" VerticalAlignment="Center" | ||
| HorizontalAlignment="Left" Text="{DynamicResource actionKeyword}" /> | ||
| <StackPanel Grid.Row="1" Orientation="Horizontal" Grid.Column="2"> | ||
| <TextBox x:Name="tbAction" Margin="10" Width="400" VerticalAlignment="Center" HorizontalAlignment="Left" /> | ||
| <Button x:Name="btnTestActionKeyword" Padding="10 5 10 5" Height="30" Click="BtnTestActionKeyword_OnClick" | ||
| Content="{DynamicResource preview}" /> | ||
| </StackPanel> | ||
|
|
||
| <StackPanel Orientation="Horizontal" HorizontalAlignment="Right" Grid.Row="2" Grid.Column="1"> | ||
| <StackPanel Orientation="Horizontal" HorizontalAlignment="Left" Grid.Row="1" Grid.Column="2" Margin="325,61,0,0" Grid.RowSpan="2"> |
Member
There was a problem hiding this comment.
is this change intentional? the button is not aligned. Can we revert this?
Member
Author
There was a problem hiding this comment.
Sorry this seems unintentioned change, I will revert it.
jjw24
approved these changes
Jan 26, 2021
Member
Author
|
Thank you! I haven't got time to revert the change.😅 |
Member
|
All good, I was just doing review thought I might as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #305
I fix most of them except for these two, which I am not sure how to add translated string to them.