Fix unrecognized path #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taooceros
force-pushed
the
ExplorerDirectorySearchWithIndexFix
branch
from
a30385c to
b426dd1
Compare
Member
Author
|
Actually, I think we shall not use this method in searchmanager to check whether it is like a path, but better to trim the end part after the last \ and use directory.exist |
Member
IsLocationPathString is used in scenario where you just do initial string validation and dont need to have the overhead of checking if the directory actually exists. |
jjw24
reviewed
Jan 24, 2021
| locationPath = EnvironmentVariables.TranslateEnvironmentVariablePath(locationPath); | ||
|
|
||
| if (!FilesFolders.LocationExists(FilesFolders.ReturnPreviousDirectoryIfIncompleteString(locationPath))) | ||
| if (!FilesFolders.ReturnPreviousDirectoryIfIncompleteString(locationPath).IsLocationPathString()) |
Member
There was a problem hiding this comment.
Reverting this change because if we dont check whether location exists, it will error when we do directory search:
Member
Author
There was a problem hiding this comment.
Forget this situation. Thank you!
jjw24
previously approved these changes
Jan 24, 2021
jjw24
approved these changes
Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #308
The reason is
IsLocationPathString(string)unable to recongnizeD:\>*as location string, so that it treat it as a file search.