Add Cancellation token for file system enumeration

[taooceros]

fix #299
Also using EnumerationOption to avoid one access denied location breaking the whole searching similar to #209 .

Outcome:

• Improved Explorer's handling of long running results
• Enhanced result list update speed

[jjw24]

Ok so found the bottleneck that causes query to run very long from explorer:

when you have a lot of results like below, and it's trying to add new results (called from updateresultview) in after using except to exclude the same results currently display, this operation is very costly:

if you let it just display the new results, blazing fast

[taooceros]

That seems what #195 is trying to do. You can take a look on the same method in that pr.

[jjw24]

Ok cool, yeah I haven't looked at the code yet, just being taking it for test drives, will do so very soon

[taooceros]

I think enumerate all file including subdirectory for about 200000 results may take about 5s and 200MB memory, which is still costly. This should still be added with an cancellation token.

[taooceros]

Ok so found the bottleneck that causes query to run very long from explorer:

if you let it just display the new results, blazing fast

Also, due to the lock strategy, by doing huge calculation within NewResutls method will hold the lock, which blocks ongoing results view update.

[jjw24]

agree and agree, wonder if there is a better way to do this. also maybe if we want to do it in separate pr so cancellation is not blocked by this other fix

[taooceros]

agree and agree, wonder if there is a better way to do this. also maybe if we want to do it in separate pr so cancellation is not blocked by this other fix

That's already exist in #195, so no worry!

[taooceros]

I also fix some code that is used for testing in #195, which isn't a big deal.

[taooceros]

After merging the dev, the recursive search for 180000 result takes about 5s to finish, which is significantly faster than before.

[taooceros]

From testing, seems that the large amount of result won't be collected by GC even after a few other queries. By changing the List capacity, it should show a memory lower down but seems no effect....
Not sure whether my testing is wrong.

[taooceros]

Unintentionally add a test code in PublicAPIInstance due to #300, should remove it before merging.

[jjw24]

Unintentionally add a test code in PublicAPIInstance due to #300, should remove it before merging.

this one?

  Application.Current.Dispatcher.Invoke(() =>
            {
                useMainWindowAsOwner = false; <=============
                var msg = useMainWindowAsOwner ? new Msg { Owner = Application.Current.MainWindow } : new Msg();
                msg.Show(title, subTitle, iconPath);
            });

[taooceros]

Unintentionally add a test code in PublicAPIInstance due to #300, should remove it before merging.

this one?

  Application.Current.Dispatcher.Invoke(() =>
            {
                useMainWindowAsOwner = false; <=============
                var msg = useMainWindowAsOwner ? new Msg { Owner = Application.Current.MainWindow } : new Msg();
                msg.Show(title, subTitle, iconPath);
            });

Yes

[jjw24]

getting this error ,

repro:
set explorer hotkey to 'e', type 'e a'. first couple of characters gets this error

[jjw24]

open flow's settings get this:

[taooceros]

open flow's settings get this:

Forget to add null check😅, will do now.

[taooceros]

getting this error ,
repro: set explorer hotkey to 'e', type 'e a'. first couple of characters gets this error

I cannot reproduce the error....Could you please provide the stacktrace for that error?

[jjw24]

getting this error ,
repro: set explorer hotkey to 'e', type 'e a'. first couple of characters gets this error

I cannot reproduce the error....Could you please provide the stacktrace for that error?

This maybe related to the null check, will check again later

[taooceros]

@jjw24 Should we try to fix #308 here or use a new pr to fix it?

[jjw24]

Separate pr please

[taooceros]

Separate pr please

Sure

[jjw24]

getting this error ,

repro:
set explorer hotkey to 'e', type 'e a'. first couple of characters gets this error

yeah ok still getting this error. Set search activation hotkey to 'e' and just type 'e' i got it.

[jjw24]

sorted in ff5e369

[taooceros]

sorted in ff5e369

Nice! I understand that why I am unable to reproduce, because I have a few quick access.

[jjw24]

yeah haha, i should have said remove roaming profile

[taooceros]

yeah haha, i should have said remove roaming profile

Hahaha 🤣

[taooceros]

9914124 remove the extra checking to make the code clear. We don't need to check whether the quick folder list is empty and don't need to check the action keyword as what we have talked about in Window Walker plugin.

[taooceros]

@jjw24 Any further change required?

[jjw24]

@taooceros do you know if this comment is still relevant?

[taooceros]

I think yes, because only results from main result set will be added via resultUpdateQueue, the one for context menu and history is still added directly.
However, I am not sure the deadlock meaning here. Maybe just avoiding potential stunt of main ui due to lock machanism.

[jjw24]

cool, thank you