Skip to content

Conversation

@z1nc0r3
Copy link
Member

@z1nc0r3 z1nc0r3 commented Jul 15, 2024

  • Added an option in Explorer > Everything Settings to enable/disable Run Count for file/folder.

fixes issue #2830

Added an option in Explorer > Everything Settings to enable/disable Run Count for file/folder.
@prlabeler prlabeler bot added the bug Something isn't working label Jul 15, 2024
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 15, 2024

Walkthrough

Walkthrough

The recent changes introduce a new feature that enables or disables a run counter for searches in the Flow Launcher plugin. This involves adding a new configuration setting, updating search management logic to incorporate this setting, and enhancing the user interface to allow toggling the run counter feature.

Changes

File Path Change Summary
.../Languages/en.xaml Added a new string key flowlauncher_plugin_everything_enable_run_count.
.../EverythingSearchManager.cs Updated SearchAsync, EnumerateAsync, and SearchAsync methods to include IsRunCounterEnabled parameter in the EverythingSearchOption constructor calls.
.../EverythingSearchOption.cs Added a boolean field IsRunCounterEnabled to the EverythingSearchOption struct.
.../ResultManager.cs Updated logic to check EverythingEnableRunCount before calling IncrementRunCounterAsync.
.../Settings.cs Added a public boolean property EverythingEnableRunCount with a default value of true.
.../ExplorerSettings.xaml Added a new CheckBox element for Settings.EverythingEnableRunCount with corresponding content and bindings.

Poem

In the land of code, a toggle anew,
A run counter's fate in your hands, it's true.
Search and explore with meticulous fare,
Enable or disable with a single check there.
Flow Launcher evolved, to better your quest,
With settings refined, it's now at its best.
Happy coding, dear users, let efficiency bloom,
As you navigate files, from dawn till noon! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@z1nc0r3 z1nc0r3 self-assigned this Jul 15, 2024
@z1nc0r3 z1nc0r3 added enhancement New feature or request Explorer Plugin Issue or Enhancement Link to Explorer Plugin everything Related to Everything and removed bug Something isn't working labels Jul 15, 2024
@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 1
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@z1nc0r3 z1nc0r3 linked an issue Jul 15, 2024 that may be closed by this pull request
@jjw24
Copy link
Member

jjw24 commented Jul 15, 2024

LGTM, does it actually fix issue 2830 (you mentioned possibly, could we confirm please)?

@jjw24 jjw24 added this to the 1.19.0 milestone Jul 15, 2024
@jjw24 jjw24 enabled auto-merge July 15, 2024 11:21
@z1nc0r3
Copy link
Member Author

z1nc0r3 commented Jul 15, 2024

Yes @jjw24 it fixes #2830

@prlabeler prlabeler bot added the bug Something isn't working label Jul 15, 2024
@jjw24 jjw24 removed bug Something isn't working 1 min review labels Jul 16, 2024
@jjw24 jjw24 merged commit a8b5463 into Flow-Launcher:dev Jul 16, 2024
@gitstream-cm
Copy link

gitstream-cm bot commented Jul 16, 2024

🥷 Code experts: no user matched threshold 10

See details

To learn more about /:\ gitStream - Visit our Docs

@gitstream-cm
Copy link

gitstream-cm bot commented Jul 16, 2024

 /:\ gitStream DRY RUN 

gitstream/estimated_time_to_review

• add label 1 min review with color 0e8a16

gitstream/explain_code_experts

• add explain code experts comment:

🥷 Code experts: Yusyuriv, onesounds

Yusyuriv, z1nc0r3 have most 👩‍💻 activity in the files.
onesounds has most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.Explorer/Languages/en.xaml

Activity based on git-commit:

Yusyuriv z1nc0r3
JUL 1 additions & 0 deletions
JUN 4 additions & 3 deletions
MAY 6 additions & 1 deletions
APR
MAR
FEB

Knowledge based on git-blame:
onesounds: 15%

Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingSearchManager.cs

Activity based on git-commit:

Yusyuriv z1nc0r3
JUL 5 additions & 3 deletions
JUN
MAY
APR
MAR
FEB

Knowledge based on git-blame:

Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingSearchOption.cs

Activity based on git-commit:

Yusyuriv z1nc0r3
JUL 2 additions & 1 deletions
JUN
MAY
APR
MAR
FEB

Knowledge based on git-blame:

Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs

Activity based on git-commit:

Yusyuriv z1nc0r3
JUL 1 additions & 1 deletions
JUN 38 additions & 1 deletions
MAY 20 additions & 38 deletions
APR
MAR
FEB

Knowledge based on git-blame:
onesounds: 4%

Plugins/Flow.Launcher.Plugin.Explorer/Settings.cs

Activity based on git-commit:

Yusyuriv z1nc0r3
JUL 1 additions & 0 deletions
JUN 7 additions & 3 deletions
MAY 11 additions & 1 deletions
APR
MAR
FEB

Knowledge based on git-blame:

Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml

Activity based on git-commit:

Yusyuriv z1nc0r3
JUL 5 additions & 0 deletions
JUN 65 additions & 10 deletions
MAY 51 additions & 0 deletions
APR
MAR
FEB

Knowledge based on git-blame:
onesounds: 72%

To learn more about /:\ gitStream - Visit our Docs

gitstream/request_screenshot

• add comment Be a legend :trophy: by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

To activate these actions - merge this PR into the main branch


Learn more on the gitStream Docs
See your automations on the Usage in LinearB
Create new rules on the gitSteam playground

@z1nc0r3 z1nc0r3 deleted the file-run-count-toggle branch July 16, 2024 14:18
@jjw24 jjw24 removed the cm-changes label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request everything Related to Everything Explorer Plugin Issue or Enhancement Link to Explorer Plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an option not to add run count of files in Everything

2 participants