Skip to content

Conversation

@onesounds
Copy link
Contributor

@onesounds onesounds commented Jun 4, 2024

What's the PR

Test Case

  • 10 You must have at least two monitors.
  • 20 In an flow(dev), change the dpi to see what happens when you get a blurry state (175, 200, 225, 250...)
  • 30 build this PR
  • 40 goto 20

@onesounds onesounds added the bug Something isn't working label Jun 4, 2024
@onesounds onesounds self-assigned this Jun 4, 2024
@VictoriousRaptor
Copy link
Contributor

VictoriousRaptor commented Jun 4, 2024

@taooceros Should we set use winforms to false? Code of pt run.
图片

@taooceros
Copy link
Member

@taooceros Should we set use winforms to false? Code of pt run. 图片

I think that would cause some compilation failure. Seems like we still use some part of winform? Though I think it is resolvable.

@onesounds onesounds added the Small PR Items that are short and don't have much impact. Quick reviews are good. label Jun 4, 2024
@onesounds
Copy link
Contributor Author

@taooceros Should we set use winforms to false? Code of pt run. 图片

I think that would cause some compilation failure. Seems like we still use some part of winform? Though I think it is resolvable.

@VictoriousRaptor @taooceros I tried (false UseWindowsForms) and The build was successful. but I've been searching too, and as taoo said, they said it does affect winform-dependent code. (but why build success?)

We can either change it to false and see what happens, or we can safely leave it at true. What do we choose?
(I confirmed that this PR is works well by working on another PR.)

@taooceros
Copy link
Member

@taooceros Should we set use winforms to false? Code of pt run. 图片

I think that would cause some compilation failure. Seems like we still use some part of winform? Though I think it is resolvable.

@VictoriousRaptor @taooceros I tried (false UseWindowsForms) and The build was successful. but I've been searching too, and as taoo said, they said it does affect winform-dependent code. (but why build success?)

We can either change it to false and see what happens, or we can safely leave it at true. What do we choose? (I confirmed that this PR is works well by working on another PR.)

If it builds, I think it will work. Let's do it and rollback if anything observed. I don't think we really use much winform related functionality.

@onesounds
Copy link
Contributor Author

@taooceros Should we set use winforms to false? Code of pt run. 图片

I think that would cause some compilation failure. Seems like we still use some part of winform? Though I think it is resolvable.

@VictoriousRaptor @taooceros I tried (false UseWindowsForms) and The build was successful. but I've been searching too, and as taoo said, they said it does affect winform-dependent code. (but why build success?)
We can either change it to false and see what happens, or we can safely leave it at true. What do we choose? (I confirmed that this PR is works well by working on another PR.)

If it builds, I think it will work. Let's do it and rollback if anything observed. I don't think we really use much winform related functionality.

OK. puhsed.

@VictoriousRaptor VictoriousRaptor merged commit 224a6b1 into Flow-Launcher:dev Jun 5, 2024
@VictoriousRaptor VictoriousRaptor added this to the 1.19.0 milestone Jun 5, 2024
@onesounds onesounds deleted the dpi-per-monitor branch June 5, 2024 15:34
@jjw24 jjw24 removed the Small PR Items that are short and don't have much impact. Quick reviews are good. label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants