Skip to content

Conversation

@onesounds
Copy link
Contributor

@onesounds onesounds commented May 31, 2024

What's the PR

Adjust Accent Button Color

  • Adjust to match winui style
  • Changed mouse over and color.
  • Add a line at the bottom of the button in the Light Color Scheme state

Before

After

Add "User Data Location" item in about page

  • Added a button to open the location of the currently used settings folder.
  • If it is portable, it should change to the portable location and open.
  • Added because users often ask for backups or locations.

Toggle Switch Focus Visual

  • Live: No focus visual

  • DEV : Focus visual entered incorrectly while making changes

  • CURRENT: Fixed the focus visual.
    image

  • I found some issues with other controls as well, but I'll put this off and work on it when Upgrad the WPF UI by MS.

Adjust Sidebar Width

  • Sometimes labels are long, like in Japanese, so I increased the length a bit. Auto Size is not supported by modernwpf, so this is what I did for now.

Fix Fullscreen Titlebar in settingwindow

  • Fixed an issue that caused the window area to be slightly larger when the window was maximized. (In this case, it feels like there is not enough margin). This issue creates a problem where the minimize/maximize buttons appear to be out of line
  • Fixed by giving some margin when maximizing.

Adjust Margin in Pages

  • The items on the general page are widely spaced, (vertical) so I've narrowed it down a bit.
  • It should feel similarly spaced to the other pages.

Test Cases

  • Open Folder behavior should be correct. (including portable mode)

@onesounds onesounds marked this pull request as ready for review June 1, 2024 16:26
@onesounds onesounds self-assigned this Jun 1, 2024
@onesounds onesounds added bug Something isn't working enhancement New feature or request kind/ui related to UI, icons, themes, etc labels Jun 1, 2024
@jjw24 jjw24 removed the enhancement New feature or request label Jun 3, 2024
@jjw24 jjw24 added this to the 1.19.0 milestone Jun 3, 2024
@jjw24 jjw24 enabled auto-merge June 3, 2024 04:11
@jjw24 jjw24 merged commit 8e31b4a into Flow-Launcher:dev Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working kind/ui related to UI, icons, themes, etc

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants