Skip to content

Conversation

@taooceros
Copy link
Member

Change Cache to Concurrentlfu in BitFaster.Caching. The eviction policy seems to be undesirable for our cases.

neon-sunset/fast-cache#107

Changes:

  • Remove the usage property in the cache, since we are not managing the cache ourselves.

Tested:

  • With a relatively small cache size, the icon is not flickering when type continuous query that consistently get the same result. (like "vscode" or "powerpoint").

@taooceros taooceros self-assigned this May 29, 2024
@taooceros taooceros added the bug Something isn't working label May 29, 2024
@onesounds
Copy link
Contributor

After changing maxcached, I noticed that when I return after keystrokes and context menu switching, the icons are not flickering and display well.

@onesounds onesounds enabled auto-merge May 30, 2024 05:51
@onesounds onesounds merged commit fe7c3e4 into dev May 30, 2024
@onesounds onesounds deleted the new-image-cache branch May 30, 2024 06:04
@jjw24 jjw24 added this to the 1.19.0 milestone Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants