Skip to content

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented Feb 16, 2024

- Fix Python plugin v2

  • Fix Node plugin (we didn't redirect input before)
  • Fix job process associate to the child process created by program plugin which causes the exit of flow causing the program being created exited.
  • Fix JsonRPCV2 plugins setting not sent via query

I don't know when but somehow python plugin doesn't pass the required argument which will create start a empty python interactive. So anyone with a python plugin v2 will simply can't run flow...

It's not as bad as I anticipated. The argument will still being passed. It's just the place is weird.

fix job process association the program plugin
@taooceros taooceros added the bug Something isn't working label Feb 16, 2024
@taooceros taooceros added this to the 1.17.3 milestone Feb 16, 2024
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@taooceros taooceros requested a review from jjw24 February 16, 2024 04:22
@taooceros taooceros changed the title fix python plugin and node plugin fix node plugin and job object association Feb 16, 2024
@VictoriousRaptor
Copy link
Contributor

Fix job process associate to the child process created by program plugin which causes the exit of flow causing the program being created exited.

I can't reproduce it. Could you describe how to reproduce it?

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@taooceros
Copy link
Member Author

Fix job process associate to the child process created by program plugin which causes the exit of flow causing the program being created exited.

I can't reproduce it. Could you describe how to reproduce it?

maybe it is dev only. I kindly forget whether #2549 is included in 1.17.2

@taooceros
Copy link
Member Author

Fix job process associate to the child process created by program plugin which causes the exit of flow causing the program being created exited.

I can't reproduce it. Could you describe how to reproduce it?

weird I can't reproduce either. I only reproduce once when I exit flow and rider associate it being killed. Though it might be good to only manually associate the subprocess

@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (11)
Deliminated
flowlauncher
IPublic
JTF
lnk
Meziantou
Nerdbank
PYTHONPATH
Reloadable
runas
Segoe
To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository
on the node-plugin-processinfo branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/7963087960/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

ℹ️ Warnings Count
ℹ️ non-alpha-in-dictionary 10

See ℹ️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@taooceros taooceros self-assigned this Feb 21, 2024
@taooceros taooceros changed the title fix node plugin and job object association fix node plugin, job object association, v2 context menu Feb 24, 2024
@taooceros
Copy link
Member Author

@jjw24 mind take a look on this? It should be pretty straightforward as you have reviewed other v2 before.

@jjw24 jjw24 modified the milestones: 1.17.3, 1.18.0 Mar 25, 2024
@jjw24 jjw24 merged commit 085de91 into dev Mar 27, 2024
@jjw24 jjw24 deleted the node-plugin-processinfo branch March 27, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants