-
-
Notifications
You must be signed in to change notification settings - Fork 457
fix node plugin, job object association, v2 context menu #2578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix job process association the program plugin
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I can't reproduce it. Could you describe how to reproduce it? |
…for everything else
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
maybe it is dev only. I kindly forget whether #2549 is included in 1.17.2 |
weird I can't reproduce either. I only reproduce once when I exit flow and rider associate it being killed. Though it might be good to only manually associate the subprocess |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (11)To accept these unrecognized words as correct, you could run the following commands... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/7963087960/attempts/1'
OR To have the bot accept them for you, reply quoting the following line: Warnings (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ℹ️ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
|
@jjw24 mind take a look on this? It should be pretty straightforward as you have reviewed other v2 before. |
- Fix Python plugin v2I don't know when but somehow python plugin doesn't pass the required argument which will create start a empty python interactive. So anyone with a python plugin v2 will simply can't run flow...It's not as bad as I anticipated. The argument will still being passed. It's just the place is weird.