Skip to content

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented Dec 16, 2020

image

@jjw24 jjw24 added the enhancement New feature or request label Dec 16, 2020
@jjw24 jjw24 self-assigned this Dec 16, 2020
taooceros
taooceros previously approved these changes Dec 16, 2020
IcoPath = "Images\\website.png",
Action = _ =>
{
SharedCommands.SearchWeb.NewBrowserWindow(pluginManifestInfo.Website);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use NewBrowserInTab?

IcoPath = "Images\\sourcecode.png",
Action = _ =>
{
SharedCommands.SearchWeb.NewBrowserWindow(pluginManifestInfo.UrlSourceCode);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as last one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, let's be consistent with this.

@jjw24
Copy link
Member Author

jjw24 commented Dec 19, 2020

Good to go? @JohnTheGr8 @taooceros

Copy link
Member

@taooceros taooceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@jjw24 jjw24 merged commit 829fccf into dev Dec 20, 2020
@jjw24 jjw24 deleted the add_pluginsmanager_contextmenu branch December 20, 2020 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants