-
-
Notifications
You must be signed in to change notification settings - Fork 455
Add context menu for PluginsManager #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jjw24
commented
Dec 16, 2020

| IcoPath = "Images\\website.png", | ||
| Action = _ => | ||
| { | ||
| SharedCommands.SearchWeb.NewBrowserWindow(pluginManifestInfo.Website); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use NewBrowserInTab?
| IcoPath = "Images\\sourcecode.png", | ||
| Action = _ => | ||
| { | ||
| SharedCommands.SearchWeb.NewBrowserWindow(pluginManifestInfo.UrlSourceCode); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as last one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, let's be consistent with this.
|
Good to go? @JohnTheGr8 @taooceros |
taooceros
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!