-
-
Notifications
You must be signed in to change notification settings - Fork 455
Expand Plugin API #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Plugin API #230
Conversation
|
@Flow-Launcher/team any idea? |
|
add some hooks, see jjw24/Wox#194
|
emmm I am not sure what do you mean for hook...... Do you mean that we should allow plugin to do more things besides querying? |
|
why we exposing action key word methods? |
To allow plugins to have more than one actionkeyword. Currently, although we allow mutiple keywords, only internal plugins can utilize it because external plugin has no access to their actionkeywords. |
|
Also, plugins won't be available to change action keywords for other plugin since they don't know the id of other plugin. |
|
Exposed the system calling function process. There would have a hook called |
Like registering an event that will be triggered before querying? But why don't we do the job when querying? to bypass the action keyword restriction? |
more than one action keyword like in websearch plugin? |
Yes, and in Explorer plugin. |
|
You should not do a stack of things in one place. And some hooks better could have global authority. before_all_user_query could do something before each plugin.
… 在 2021年1月9日,15:03,taooceros ***@***.***> 写道:
Exposed the system calling function process.
There would have a hook called before_user_query.
It means to do something before the query.
A simple example is that it could be used to log querying words.
Like registering an event that will be triggered before querying? But why don't we do the job when querying?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
i think i have also done some changes on this stringmatcher migration but got distracted. I might merge them in if feasible and ok |
Do you want it to be activated for plugins? Like an event, allowing plugin to do something here, that will be triggered before plugin querying every time user is querying. Or it is simply something that we just do in Flow. |
|
@Zeroto521 Let's move that discussion to #267 , since this pr is majorly focusing on the APIs lie in IPublicAPI. |
# Conflicts: # Flow.Launcher.Plugin/IPublicAPI.cs
#220
Expand IPublicAPI for plugin users to use.
Detail Implementation require further discussion.