Skip to content

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented Dec 5, 2020

#220

Expand IPublicAPI for plugin users to use.

  1. StringMatcher.FuzzySearch()
  2. Http.GetAsync & Http.GetStreamAsync & Http.DownloadAsync
  3. Add & remove ActionKeyword

Detail Implementation require further discussion.

@taooceros taooceros marked this pull request as ready for review January 8, 2021 08:40
@taooceros
Copy link
Member Author

@Flow-Launcher/team any idea?

@Zeroto521
Copy link
Member

add some hooks, see jjw24/Wox#194

I want to be hook master.

@taooceros
Copy link
Member Author

taooceros commented Jan 8, 2021

add some hooks, see jjw24/Wox#194

I want to be hook master.

emmm I am not sure what do you mean for hook...... Do you mean that we should allow plugin to do more things besides querying?

@jjw24
Copy link
Member

jjw24 commented Jan 9, 2021

why we exposing action key word methods?

@taooceros
Copy link
Member Author

why we exposing action key word methods?

To allow plugins to have more than one actionkeyword. Currently, although we allow mutiple keywords, only internal plugins can utilize it because external plugin has no access to their actionkeywords.

@taooceros
Copy link
Member Author

Also, plugins won't be available to change action keywords for other plugin since they don't know the id of other plugin.

@Zeroto521
Copy link
Member

Exposed the system calling function process.

There would have a hook called before_user_query.
It means to do something before the query.
A simple example is that it could be used to log querying words.

@taooceros
Copy link
Member Author

taooceros commented Jan 9, 2021

Exposed the system calling function process.

There would have a hook called before_user_query.
It means to do something before the query.
A simple example is that it could be used to log querying words.

Like registering an event that will be triggered before querying? But why don't we do the job when querying? to bypass the action keyword restriction?

@jjw24
Copy link
Member

jjw24 commented Jan 9, 2021

why we exposing action key word methods?

To allow plugins to have more than one actionkeyword. Currently, although we allow mutiple keywords, only internal plugins can utilize it because external plugin has no access to their actionkeywords.

more than one action keyword like in websearch plugin?

@taooceros
Copy link
Member Author

why we exposing action key word methods?

To allow plugins to have more than one actionkeyword. Currently, although we allow mutiple keywords, only internal plugins can utilize it because external plugin has no access to their actionkeywords.

more than one action keyword like in websearch plugin?

Yes, and in Explorer plugin.

@Zeroto521
Copy link
Member

Zeroto521 commented Jan 9, 2021 via email

@jjw24
Copy link
Member

jjw24 commented Jan 9, 2021

i think i have also done some changes on this stringmatcher migration but got distracted. I might merge them in if feasible and ok

@taooceros
Copy link
Member Author

You should not do a stack of things in one place. And some hooks better could have global authority. before_all_user_query could do something before each plugin.

Do you want it to be activated for plugins? Like an event, allowing plugin to do something here, that will be triggered before plugin querying every time user is querying. Or it is simply something that we just do in Flow.

@taooceros
Copy link
Member Author

@Zeroto521 Let's move that discussion to #267 , since this pr is majorly focusing on the APIs lie in IPublicAPI.

# Conflicts:
#	Flow.Launcher.Plugin/IPublicAPI.cs
@jjw24 jjw24 added the enhancement New feature or request label Jan 26, 2021
@jjw24 jjw24 merged commit d3127b7 into Flow-Launcher:dev Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants