Skip to content

Conversation

@VictoriousRaptor
Copy link
Contributor

Closes #2147

Add string GetLastQueryMode() API to get LastQueryMode.

Tests:

  • Query is empty after killing a process if LastQueryMode == Selected
  • Requery is done after killing a process if LastQueryMode != Selected

@VictoriousRaptor VictoriousRaptor added bug Something isn't working enhancement New feature or request labels May 27, 2023
@VictoriousRaptor VictoriousRaptor self-assigned this May 27, 2023
@VictoriousRaptor VictoriousRaptor added this to the 1.15.1 milestone May 27, 2023
/// Get Settings.LastQueryMode
/// Possible return values: "Empty", "Selected", "Preserved"
/// </summary>
public string GetLastQueryMode();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use enum?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does enum support JSON rpc plugins? I wasn't sure.

@VictoriousRaptor VictoriousRaptor deleted the fix-kill-empty-query branch June 4, 2023 05:44
@jjw24 jjw24 removed this from the 1.15.1 milestone Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

BUG: "Kill" command not deleted after use

3 participants