Skip to content

Release 1.4.1 #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Release 1.4.1 #215

wants to merge 4 commits into from

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented Nov 19, 2020 •
edited
Loading

Release Notes

Bug fixes

@jjw24 jjw24 added the release Release PR which contains the changes going into the upcoming release label Nov 19, 2020
@jjw24 jjw24 self-assigned this Nov 19, 2020
@jjw24 jjw24 marked this pull request as draft November 19, 2020 10:11
@jjw24 jjw24 marked this pull request as ready for review November 19, 2020 19:02
@JohnTheGr8
Copy link
Member

JohnTheGr8 commented Nov 20, 2020

@jjw24 why don't we go with #207 instead?

@taooceros
Copy link
Member

taooceros commented Nov 20, 2020

@jjw24 why don't we go with #207 instead?

I think @jjw24 wants to publish the large bug fix faster, since #207 will include more feature enhancement.

@JohnTheGr8
Copy link
Member

JohnTheGr8 commented Nov 20, 2020

I see no reason not to release everything included in #207 if we're going to make a release...

JohnTheGr8
JohnTheGr8 requested changes Nov 20, 2020
View reviewed changes
Copy link
Member

@JohnTheGr8 JohnTheGr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we can release all changes from #207. No good reason to selectively pick these changes...

Disapproving this PR because merging it to master will cause a CI failure (as I have mentioned to @jjw24 before).

@jjw24 jjw24 closed this Nov 22, 2020
@jjw24 jjw24 deleted the release_bug_fixes branch November 22, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTheGr8 JohnTheGr8 JohnTheGr8 requested changes

@taooceros taooceros taooceros approved these changes

@Zeroto521 Zeroto521 Awaiting requested review from Zeroto521

@gdziedzic gdziedzic Awaiting requested review from gdziedzic

@kalaschnik kalaschnik Awaiting requested review from kalaschnik

@SysC0mp SysC0mp Awaiting requested review from SysC0mp

Assignees

@jjw24 jjw24

Labels

release Release PR which contains the changes going into the upcoming release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jjw24 @JohnTheGr8 @taooceros