Plugin Store search (should) work after refresh button clicked #2137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you so much for the fix! Would you please check whether it is possible to fix this bug while keeping using Command instead of a method callback? It doesn't seem to matter here but it might be better to keep the code consistent. |
ngtr6788
force-pushed
the
search-plugin-store-refresh
branch
from
9cb01c3 to
c5a4e4f
Compare
ngtr6788
force-pushed
the
search-plugin-store-refresh
branch
from
c5a4e4f to
eaaf7c2
Compare
Author
Well, turns out it is possible. I just updated the PR :). You can take a look. |
VictoriousRaptor
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2049.
Hello everyone! This is my first time contributing to Flow Launcher, and I am very new at C# in general. My goal is (hopefully) get all the latest plugins into the store and show all the most up-to-date installed plugins, and allow the search function to work even after the refresh button is clicked. Can anyone check that the implementation is correct, and if not, let me know if there are any fixes?
Thanks so much!