add Terminal to shell plugin settings

[ThinkSalat]

fixes #2043

Adds Terminal to the list of shells available for running shell commands.

[TheBestPessimist]

1. Would it make sense for this to be named Windows Terminal ?
2. Do we need translations for this?

[ThinkSalat]

It's just called Terminal, and flow launcher is windows only, so I don't think the distinction is necessary. As for translations, the other options aren't translated, so it kind of be adding too much responsibility to this PR.

[VictoriousRaptor]

When I test it I got the following error

[ThinkSalat]

When I test it I got the following error

Looking into it

[VictoriousRaptor]

Related to #1116

[Azakidev]

Hi,

This happens because the arguments given are for pwsh, not for windows terminal
It should specify the shell that will open and use the correct arguments if needed

It would look something like this for powershell and cmd respectively:

case Shell.TerminalPWSH:
{
    info.FileName = "wt.exe";
    info.ArgumentList.Add(pwsh)
    if (_settings.LeaveShellOpen)
    {
        info.ArgumentList.Add("-NoExit");
        info.ArgumentList.Add("-c");
        info.ArgumentList.Add(command);
    }
    else
    {
        info.ArgumentList.Add("-c");
        info.ArgumentList.Add(command);
    }
    break;
}

case Shell.TerminalCMD:
{
    info.FileName = "wt.exe";
    info.ArgumentList.Add(cmd)
    if (_settings.LeaveShellOpen)
    {
        info.ArgumentList.Add("/k");
        info.ArgumentList.Add(command);
    }
    else
    {
        info.ArgumentList.Add("/c");
        info.ArgumentList.Add(command);
    }
    break;
}

Ideally it would automatically use the default profile and none of this would be necessary, but I'm not quite sure if it can as of now

[Azakidev]

After looking just a bit more
It's pretty much how Powertoys run does it.
As can be seen in their implementation.

Hope this helps!

[VictoriousRaptor]

Close as #3225 implements it.