Skip to content

Conversation

@taooceros
Copy link
Member

Link to #201
Add a quick link to access user theme folder.
image

If anyone would like to make it looks better, feel free to do it!

@taooceros
Copy link
Member Author

Why do the check fail.....I think there isn't any significant change that may affect the check.

@jjw24
Copy link
Member

jjw24 commented Nov 15, 2020

Why do the check fail.....I think there isn't any significant change that may affect the check.

Error from CI:
C:\Program Files\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error NETSDK1005: Assets file 'C:\projects\flow-launcher\Plugins\Flow.Launcher.Plugin.WebSearch\obj\project.assets.json' doesn't have a target for 'netcoreapp3.1'. Ensure that restore has run and that you have included 'netcoreapp3.1

I am afk, can u check if the project websearch has the target framework in project file, pretty sure it does

@taooceros
Copy link
Member Author

image
I think it does have the target framework that is as intended. This branch should not contains things about .net 5. Weird.....

@taooceros
Copy link
Member Author

Oh maybe it is because that I push too fast that the restoration of project file hasn't been restored successfully. Let me push something it later and check whether that can solve this.

@JohnTheGr8
Copy link
Member

@jjw24 @taooceros build failures should be resolved with #206

@jjw24
Copy link
Member

jjw24 commented Nov 15, 2020

Thanks for the fix both 👍

@taooceros i changed the code to open path using FilesFolders class + move the word Themes to Constant class as it is now used in more than one place.

@jjw24 jjw24 added the enhancement New feature or request label Nov 15, 2020
@jjw24 jjw24 self-requested a review November 15, 2020 19:18
@jjw24 jjw24 merged commit 98630d1 into Flow-Launcher:dev Nov 15, 2020
@taooceros taooceros deleted the theme_folder_quicklink branch November 15, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants