Skip to content

Bookmark Plugin fix #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 1, 2020
Merged

Bookmark Plugin fix #190

merged 4 commits into from
Nov 1, 2020

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented Oct 26, 2020

  1. Add Edge Dev Bookmark to the cache list
  2. Use the fuzzy search score as the result score

jjw24
jjw24 reviewed Nov 1, 2020
View reviewed changes
@jjw24
Copy link
Member

jjw24 commented Nov 1, 2020

sorry not sure if this PR is actually ready for review... let me know if it is not. Otherwise the usual way is when a review is requested, it means the PR is ready

@taooceros
Copy link
Member Author

taooceros commented Nov 1, 2020

sorry not sure if this PR is actually ready for review... let me know if it is not. Otherwise the usual way is when a review is requested, it means the PR is ready

It is ready for review. Thank you for reviewing. I think if the PR is not ready for review, people should keep it as draft so that it will be more easy for us to know whether it is ready.

@jjw24
Copy link
Member

jjw24 commented Nov 1, 2020

sorry not sure if this PR is actually ready for review... let me know if it is not. Otherwise the usual way is when a review is requested, it means the PR is ready

It is ready for review. Thank you for reviewing. I think if the PR is not ready for review, people should keep it as draft so that it will be more easy for us to know whether it is ready.

yeah i am ok for that as well :)

@jjw24 jjw24 added the enhancement New feature or request label Nov 1, 2020
@jjw24
Copy link
Member

jjw24 commented Nov 1, 2020

Hey btw, thank for all the great changes. Would you also be keen to join the Flow team?

@jjw24 jjw24 added the review in progress Indicates that a review is in progress for this PR label Nov 1, 2020
@taooceros
Copy link
Member Author

taooceros commented Nov 1, 2020

Hey btw, thank for all the great changes. Would you also be keen to join the Flow team?

Sure, it is my pleasure to join the Flow team!

@jjw24
Copy link
Member

jjw24 commented Nov 1, 2020 •
edited
Loading

Hey btw, thank for all the great changes. Would you also be keen to join the Flow team?

Sure, it is my pleasure to join the Flow team!

Awesome! I have sent you an invite. Feel free to jump on Discord if you need to ask anything as well https://discord.gg/AvgAQgh

@taooceros
Copy link
Member Author

taooceros commented Nov 1, 2020

Hey btw, thank for all the great changes. Would you also be keen to join the Flow team?

Sure, it is my pleasure to join the Flow team!

Awesome! I have sent you an invite. Feel free to jump on Discord if you need to ask anything as well https://discord.gg/AvgAQgh

Thank you!

@jjw24
Copy link
Member

jjw24 commented Nov 1, 2020

Lets bump BrowserBookmark plugin version, I think these are enhancements right?

Also the PinyinName property if we want to remove it entirely?

Once those sorted I think this is good to go too

@taooceros
Copy link
Member Author

taooceros commented Nov 1, 2020 •
edited
Loading

Lets bump BrowserBookmark plugin version, I think these are enhancements right?

Also the PinyinName property if we want to remove it entirely?

Once those sorted I think this is good to go too

Done it. Good to go!

@jjw24 jjw24 added bug Something isn't working and removed enhancement New feature or request labels Nov 1, 2020
@jjw24 jjw24 merged commit c254c93 into Flow-Launcher:dev Nov 1, 2020
@jjw24 jjw24 removed the review in progress Indicates that a review is in progress for this PR label Nov 1, 2020
@jjw24 jjw24 mentioned this pull request Nov 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjw24 jjw24 jjw24 approved these changes

Assignees

@taooceros taooceros

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taooceros @jjw24