-
-
Notifications
You must be signed in to change notification settings - Fork 456
Custom Browser managing UI Improvement in Bookmarks Plugin #1897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Browser managing UI Improvement in Bookmarks Plugin #1897
Conversation
- Added 'Edit' Button, It will be disable when non-select situation - Added Browse Button in Path Select Textbox
Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@VictoriousRaptor 'auto reload' works fine. but... we forgot the chrome / edge / firefox checkboxes. 😅 (it doesn't work with auto reload) Please make this check box action a trigger for auto reload, too. |
Ahh my bad. Please review again. |
I see it's working fine. 👏 |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view or the 📜action log for details. Unrecognized words (3)browers To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands... in a clone of the [email protected]:onesounds/Flow.Launcher.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/4180107983/attempts/1'If the flagged items are 🤯 false positivesIf items relate to a ...
|
What's the PR
While I was testing the related pr myself, I found that bookmark registration was not clear to beginners. There is no error in trying to register the wrong file, and you have to go through cumbersome work to test the behavior of the right bookmark you registered.
Test Cases
Memo
Also, if it is registered normally, it would be good to have logic to reload the plug-in automatically. If we have this logic, I can delete the third guide description. (I feel this guide is too long.)