Skip to content

Conversation

@onesounds
Copy link
Contributor

@onesounds onesounds commented Feb 10, 2023

What's the PR

While I was testing the related pr myself, I found that bookmark registration was not clear to beginners. There is no error in trying to register the wrong file, and you have to go through cumbersome work to test the behavior of the right bookmark you registered.

  • Added guide Texts in custom browser popup window
  • Added Edit Button. It will be disable when non-select item situation
  • Added Browse Button in Path Select Textbox.
  • Auto-reload bookmark data after adding/editing/deleting custom browers and toggling Chrome/Firefox/Edge.

Test Cases

  • 'The Browse button should operate normally. This button should only allow you to select folders.
  • The Edit button must be disabled in the correct situation.
  • Guide text contains no miss typos and statements are correct.
  • Bookmarks can be automatically reloaded when finish editing. (For checkboxes and dialogs)

Memo

  • The folder selection dialog is available only in windows.forms. It was not available as usual, so I found out that I had to add a separate reference to the plug-in. I need to make sure what I did was right.
  • When attempting to register, review whether the bookmark location is correct, and if there is a problem, it would be better not to register. (There should also be messages such as 'There is no bookmark data in that location' and 'We have verified and registered bookmark data') ← I don't know how to do this.
  • Also, if it is registered normally, it would be good to have logic to reload the plug-in automatically. If we have this logic, I can delete the third guide description. (I feel this guide is too long.)

- Added 'Edit' Button, It will be disable when non-select situation
- Added Browse Button in Path Select Textbox
taooceros
taooceros previously approved these changes Feb 11, 2023
@VictoriousRaptor

This comment was marked as outdated.

@VictoriousRaptor

This comment was marked as outdated.

@onesounds
Copy link
Contributor Author

onesounds commented Feb 14, 2023

@VictoriousRaptor 'auto reload' works fine. but... we forgot the chrome / edge / firefox checkboxes. 😅 (it doesn't work with auto reload) Please make this check box action a trigger for auto reload, too.

@VictoriousRaptor
Copy link
Contributor

@VictoriousRaptor 'auto reload' works fine. but... we forgot the chrome / edge / firefox checkboxes. 😅 (it doesn't work with auto reload) Please make this check box action a trigger for auto reload, too.

Ahh my bad. Please review again.

@onesounds
Copy link
Contributor Author

@VictoriousRaptor 'auto reload' works fine. but... we forgot the chrome / edge / firefox checkboxes. 😅 (it doesn't work with auto reload) Please make this check box action a trigger for auto reload, too.

Ahh my bad. Please review again.

I see it's working fine. 👏
This PR is mine, so either you or TAOO should review it.

@onesounds onesounds self-assigned this Feb 15, 2023
@onesounds onesounds added enhancement New feature or request kind/ui related to UI, icons, themes, etc labels Feb 15, 2023
@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (3)

browers
checkboxes
Firefox

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:onesounds/Flow.Launcher.git repository
on the GuideForBookmarkPlugin branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/4180107983/attempts/1'
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@VictoriousRaptor VictoriousRaptor merged commit d3025a6 into Flow-Launcher:dev Feb 15, 2023
@jjw24 jjw24 added this to the 1.14.0 milestone Feb 21, 2023
@jjw24 jjw24 mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request kind/ui related to UI, icons, themes, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants