Adjust sidebar texts in setting window #1895
Conversation
- Added Plural key for other langues
onesounds
changed the title
|
Did we want to add the change 'Themes' tab to 'Appearance' to this PR as well? |
I forgot. I'll reflect it in this pr. |
onesounds
changed the title
- Added New key for apperance
| <system:String x:Key="searchplugin_Noresult_Title">No results found</system:String> | ||
| <system:String x:Key="searchplugin_Noresult_Subtitle">Please try a different search.</system:String> | ||
| <system:String x:Key="plugin">Plugin</system:String> | ||
| <system:String x:Key="plugins">Plugins</system:String> |
There was a problem hiding this comment.
Just update en.xaml should be fine. This is fairly annoying to update all files
There was a problem hiding this comment.
You will not understand this. People with low IQs usually work like this.
There was a problem hiding this comment.
Na I just want to inform you the fact so next time you don't have to do it🤣
There was a problem hiding this comment.
kidding, actaully I also knew that adding an English key would reflect other languages.
but anyway If I follow you, doesn't every other language display "plugins(english)"?
I don't want to affect other languages, so I copied all the 'plugin' values into the 'plugins'.
If I didn't want to influence other languages, isn't this the right way to do it?
There was a problem hiding this comment.
The issue is crowdin won't automatically load translation (which means unless we do a manually upload translation (which sometimes introduce weird thing), the update won't work and will be replaced in next crowdin merge)....and I think it's ok to let translator revises the string if we change the source string. Sometimes crowdin can detect the change from plugin->plugins and will revise the translation in other language as well.
There was a problem hiding this comment.
So should we revert non-English changes?
There was a problem hiding this comment.
No no need for that. I am just saying it won't be flushed into crowdin automatically
5 participants
What's the PR
Fix PROPOSAL. Language file. Singular/Plural #1888
Change Hotkey/Plugin title area to plural (Hotkeys / plugins)
Fix Hotkey tab's singular texts : hotkeys / shortcuts
Other languages have added key values and pasted existing text.
'Themes' To 'Appearance'
Test Case