Skip to content

Conversation

@VictoriousRaptor
Copy link
Contributor

@VictoriousRaptor VictoriousRaptor commented Feb 3, 2023

Close #1856

Add a combobox in add custom browser dialog to choose browser engine (chromium or Firefox)
图片

图片

Test:

  • Firefox bookmarks can be searched by adding data folder path to custom browser

@VictoriousRaptor VictoriousRaptor marked this pull request as ready for review February 3, 2023 09:30
@VictoriousRaptor VictoriousRaptor self-assigned this Feb 3, 2023
@VictoriousRaptor VictoriousRaptor added the enhancement New feature or request label Feb 3, 2023
@VictoriousRaptor VictoriousRaptor changed the title Add custom firefox browser location [Bookmarks Plugin] Add custom firefox browser support Feb 3, 2023
@VictoriousRaptor VictoriousRaptor added this to the 1.12.2 milestone Feb 3, 2023
@taooceros
Copy link
Member

Nice! Next time mind add a screenshot for the description?

@taooceros
Copy link
Member

taooceros commented Feb 4, 2023

image
Please also add the browser type here (should be very easy).

@github-actions

This comment has been minimized.

@VictoriousRaptor
Copy link
Contributor Author

image Please also add the browser type here (should be very easy).

Added. Please check.

@VictoriousRaptor VictoriousRaptor deleted the SelectBrowserCore branch February 6, 2023 17:33
@jjw24 jjw24 removed this from the 1.12.2 milestone Feb 6, 2023
@VictoriousRaptor VictoriousRaptor restored the SelectBrowserCore branch February 9, 2023 04:13
@github-actions

This comment has been minimized.

@VictoriousRaptor
Copy link
Contributor Author

Deleted the branch accidentally.

@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (1)

combobox

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:VictoriousRaptor/Flow.Launcher.git repository
on the SelectBrowserCore branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/4140158535/attempts/1'
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@onesounds
Copy link
Contributor

I tested this. There was a moment when it worked, but not after that.
(I installed a browser called librewolf and tested it.)
As I know, Firefox-based browsers store bookmarks in the places.sqlite file. Do I have to designate this?

I checked that it works if I specify a directory.

There is no need to modify it in this pr, but I take notes in case I forget it.

  • There is no edit button
  • It would be nice to have a guide text to specify a path, not a file.
  • It would be nice to have a "browse" button.

@onesounds onesounds merged commit 1c95033 into Flow-Launcher:dev Feb 10, 2023
@VictoriousRaptor VictoriousRaptor added this to the 1.13.1 milestone Feb 11, 2023
@jjw24 jjw24 modified the milestones: 1.13.1, 1.14.0 Feb 21, 2023
@jjw24 jjw24 mentioned this pull request Mar 2, 2023
@VictoriousRaptor VictoriousRaptor deleted the SelectBrowserCore branch April 3, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Plugin: BrowserBookmarks] Support for custom Firefox location.

4 participants